Skip to content

Allow for different default units#239

Draft
PreisTo wants to merge 57 commits into
threeML:devfrom
PreisTo:sampling_units
Draft

Allow for different default units#239
PreisTo wants to merge 57 commits into
threeML:devfrom
PreisTo:sampling_units

Conversation

@PreisTo
Copy link
Copy Markdown
Contributor

@PreisTo PreisTo commented Nov 21, 2025

- created a set_units function to manually set the units used in the analysis (must be called before creating threeML and astromodels objects)

  • added Units dataclass to the config instead of hard-coding the default units

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 21, 2025

Codecov Report

❌ Patch coverage is 79.53020% with 61 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.04%. Comparing base (ec6d6cf) to head (c767f95).
⚠️ Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #239      +/-   ##
==========================================
+ Coverage   79.79%   80.04%   +0.25%     
==========================================
  Files          47       47              
  Lines        5958     6149     +191     
==========================================
+ Hits         4754     4922     +168     
- Misses       1204     1227      +23     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ndilalla
Copy link
Copy Markdown
Contributor

ndilalla commented Dec 2, 2025

@PreisTo Is this PR ready for review or still draft?

@PreisTo
Copy link
Copy Markdown
Contributor Author

PreisTo commented Dec 2, 2025

@ndilalla that's sadly still a draft - I am still going to need a couple of more days:/

@ndilalla
Copy link
Copy Markdown
Contributor

ndilalla commented Dec 2, 2025

@ndilalla that's sadly still a draft - I am still going to need a couple of more days:/

No worries at all! I asked because I saw that you requested my review and I wanted to make sure the PR was ready :-)

@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants