This repository was archived by the owner on Mar 27, 2022. It is now read-only.
Create install.gup for system-wide install#195
Open
Lesik wants to merge 5 commits intotimbertson:masterfrom
Lesik:patch-1
Open
Create install.gup for system-wide install#195Lesik wants to merge 5 commits intotimbertson:masterfrom Lesik:patch-1
Lesik wants to merge 5 commits intotimbertson:masterfrom
Lesik:patch-1
Conversation
timbertson
reviewed
Jul 29, 2017
| here="$(pwd)" | ||
| gup --always | ||
|
|
||
| dest="$PREFIX/usr/share/gnome-shell/extensions/shellshape@gfxmonk.net" |
Owner
There was a problem hiding this comment.
This will fail if PREFIX isn't set, since I use -u in the shebang line. "${PREFIX:-}/usr/..." should work
Owner
|
Looks OK, aside from one issue (commented). Could you change it to root-install or system-install? There is no uninstall, and I don't want people to think this is an encouraged action (I discourage system-wide installation). |
Author
|
Thanks for the feedback. As mentioned in issue #198, there are some other problems with this gup script. The useless |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't use gup so I'm not sure if this is all that's required or whether something is missing.