Store LyricPriority object in priorities_dict#138
Open
yonib05 wants to merge 1 commit intotimmo001:masterfrom
Open
Store LyricPriority object in priorities_dict#138yonib05 wants to merge 1 commit intotimmo001:masterfrom
yonib05 wants to merge 1 commit intotimmo001:masterfrom
Conversation
The get_thermostat_rooms method now stores the full LyricPriority object keyed by device MAC address, making priority_type and selected_rooms accessible to consumers without additional API calls.
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_thermostat_roomscurrently parses the priority API response but only stores the room objects, discarding theLyricPrioritywrapper. This means consumers can't readcurrent_priority.priority_typeorcurrent_priority.selected_roomswithout making another API call.This adds a
priorities_dictproperty (keyed by device MAC, same asrooms_dict) that stores the fullLyricPriorityobject.Needed for an upcoming Home Assistant PR that adds a select entity to control room priority — it needs to read the current priority type and selected rooms from the coordinator data.
Related: #134 (update_priority fix)