Fix missing ARGV.next and incomplete detection of LaunchDaemons#19
Closed
overhacked wants to merge 2 commits intotimsutton:masterfrom
Closed
Fix missing ARGV.next and incomplete detection of LaunchDaemons#19overhacked wants to merge 2 commits intotimsutton:masterfrom
ARGV.next and incomplete detection of LaunchDaemons#19overhacked wants to merge 2 commits intotimsutton:masterfrom
Conversation
Already partially addressed in timsutton#16, but that PR missed one call to the non-existent `Array.next`.
Current behavior is to check for the existence of `Formula.plist` to see if there is a LaunchDaemon to be included in the package, but `Formula.service` can also define a LaunchDaemon. Check for either, and the rest of the conditional code works as-is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew-pkgresults in an error when accessingARGVthatArrayhas no methodnext. Fix ARGV.next method not found #16 already partially addresses the missingARGV.nexterrors, but it missed one. All Fix ARGV.next method not found #16's changes are included in this PR.brew-pkgdetects formulae withLaunchDaemons by testing forFormula.plist, but aLaunchDaemoncan also be defined byFormula.service. Changed the conditional to check for existence of either. The rest of theLaunchDaemonwriting code works as-is.