feat(codex): support image references for Responses imagegen and add playground UI#1024
Open
0x0079 wants to merge 3 commits into
Open
feat(codex): support image references for Responses imagegen and add playground UI#10240x0079 wants to merge 3 commits into
0x0079 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
buildImageGenerationResponsesRequestto appendinput_imagecontent items (withimage_url) after the prompt when reference URLs are present in theImageGenerateParamspayload.extractImageReferencesFromImageGenerateRequestandnormalizeStringSliceto parseinput_image_refs,image_urls, orreference_imagesarrays from the image generation request body and normalize them safely.frontend/src/pages/scenario/PlaygroundPage.tsxto addimageRefsstate, a multiline text input for one-URL-per-line references, and forward references viaextra_body.input_image_refsinclient.images.generate(...).gofmt).Testing
gofmt -w internal/client/codex_client.gosuccessfully.npm --prefix frontend run -s lint -- frontend/src/pages/scenario/PlaygroundPage.tsx, which completed successfully but reported unrelated pre-existing warnings.go test ./internal/client -run TestCodex -count=1, which failed in this environment due to a missing local replacement module (libs/anthropic-sdk-go) unrelated to the changes, so unit tests could not be fully executed here.Codex Task