Skip to content

docs(gmeet-parity): row 15 codec-gap status post #1251 build infra (#1223)#1282

Merged
senamakel merged 1 commit intotinyhumansai:mainfrom
oxoxDev:docs/1223-codec-gap-status
May 6, 2026
Merged

docs(gmeet-parity): row 15 codec-gap status post #1251 build infra (#1223)#1282
senamakel merged 1 commit intotinyhumansai:mainfrom
oxoxDev:docs/1223-codec-gap-status

Conversation

@oxoxDev
Copy link
Copy Markdown
Contributor

@oxoxDev oxoxDev commented May 6, 2026

Summary

  • Update docs/qa/GMEET-PARITY.md row 15 to reflect that the Chrome-branded CEF build infrastructure landed in scripts/cef-with-codecs/ via feat(cef-build): proprietary-codec build infra for Gmeet dynamic backgrounds (#1223) #1251.
  • Restate the remaining codec-gap blockers as operational, not code: AVC license clearance + multi-GB CEF binary hosting + tauri-cef re-pin.
  • Re-point the sign-off action item from the now-stale #1053 reference to #1223 as the umbrella for the codec-built CEF rollout.

Problem

After #1251 merged the scripts/cef-with-codecs/ build scripts (Chrome-branded FFmpeg via automate-git.py, install-local.sh, license posture memo), the GMEET-PARITY audit doc was still telling readers that the next step was "filing a follow-up against tinyhumansai/tauri-cef" and that the row-15 work was "out of scope for openhuman code". Both statements were accurate on 2026-05-05 and stale on 2026-05-06 — the openhuman-side build infra now exists; what's missing is the legal sign-off and a binary host.

Issue #1223 has been open since 2026-05-05 because PR #1251 shipped without a Closes keyword. The umbrella tracker for the codec-built CEF rollout therefore still read as "needs investigation" to anyone scanning the issue list, even though the code-side investigation work is done.

Solution

Doc-only update to row 15 of docs/qa/GMEET-PARITY.md:

Auto-memory feedback_cef_runtime_gaps.md gap #3 was updated in parallel (outside this repo, in the local memory store) so future sessions surface the new status; that file is not part of the diff.

No code, scripts, build config, or vendored-binary changes — this is purely a documentation correctness fix that retires a stale instruction.

Submission Checklist

If a section does not apply to this change, mark the item as N/A with a one-line reason. Do not delete items.

  • N/A: docs-only change — no behavior, no test surface added or modified. Tests added or updated (happy path + at least one failure / edge case) per docs/TESTING-STRATEGY.md
  • N/A: docs-only change — no executable lines for diff-cover to evaluate. Diff coverage ≥ 80% — changed lines (Vitest + cargo-llvm-cov merged via diff-cover) meet the gate enforced by .github/workflows/coverage.yml. Run pnpm test:coverage and pnpm test:rust locally; PRs below 80% on changed lines will not merge.
  • N/A: behaviour-only change — feature rows in the matrix are unaffected (this PR edits a QA-audit doc, not the capability catalog). Coverage matrix updated — added/removed/renamed feature rows in docs/TEST-COVERAGE-MATRIX.md reflect this change (or N/A: behaviour-only change)
  • All affected feature IDs from the matrix are listed in the PR description under ## Related
  • No new external network dependencies introduced (mock backend used per docs/TESTING-STRATEGY.md)
  • N/A: no release-cut surface touched — this only edits an audit doc, not the manual smoke list. Manual smoke checklist updated if this touches release-cut surfaces (docs/RELEASE-MANUAL-SMOKE.md)
  • Linked issue closed via Closes #NNN in the ## Related section

Impact

Related


AI Authored PR Metadata (required for Codex/Linear PRs)

Keep this section for AI-authored PRs. For human-only PRs, mark each field N/A.

Linear Issue

  • Key: N/A
  • URL: N/A

Commit & Branch

  • Branch: docs/1223-codec-gap-status
  • Commit SHA: 9c2cd3e

Validation Run

  • N/A: docs-only change — no TS/JSX touched. pnpm --filter openhuman-app format:check
  • N/A: docs-only change — no TS/JSX touched. pnpm typecheck
  • N/A: docs-only change — no test files touched. Focused tests:
  • N/A: docs-only change — no Rust touched. Rust fmt/check (if changed):
  • N/A: docs-only change — no Rust touched. Tauri fmt/check (if changed):

Validation Blocked

  • command: N/A
  • error: N/A
  • impact: N/A

Behavior Changes

  • Intended behavior change: none (documentation correctness only).
  • User-visible effect: none in the running app; readers of the QA audit see updated row-15 status pointing to scripts/cef-with-codecs/ and the operational blockers list.

Parity Contract

  • Legacy behavior preserved: yes — no behavior surface touched.
  • Guard/fallback/dispatch parity checks: N/A — no dispatch / guard / fallback code in scope.

Summary by CodeRabbit

  • Documentation
    • Updated QA documentation with expanded diagnostic details for background effects testing, including codec analysis and build infrastructure guidance, alongside refreshed test results and clarified follow-up action items.

…ild infra (tinyhumansai#1223)

Reflect that the Chrome-branded CEF build infrastructure landed in
scripts/cef-with-codecs/ via tinyhumansai#1251. Code-side work for the proprietary
codec gap is complete; remaining blockers are operational (license
clearance + binary hosting), not code.

Sign-off action items updated to track tinyhumansai#1223 as the umbrella for the
codec-built CEF rollout (license + hosting + tauri-cef re-pin) instead
of the now-stale tinyhumansai#1053 reference.

Closes tinyhumansai#1223
@oxoxDev oxoxDev requested a review from a team May 6, 2026 09:41
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 6, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8255458f-b8a6-484a-ba0b-cb05fefec1e9

📥 Commits

Reviewing files that changed from the base of the PR and between a3a1843 and 9c2cd3e.

📒 Files selected for processing (1)
  • docs/qa/GMEET-PARITY.md

📝 Walkthrough

Walkthrough

The Google Meet parity QA documentation was updated to reflect Phase A diagnostic results and revised follow-up actions. The Background effects section expanded from a partial-status note to a detailed narrative covering codec limitations and build-infra guidance. The Sign-off section was refreshed with updated results, dates, and explicit next-step references.

Changes

QA Documentation Update

Layer / File(s) Summary
Phase A Diagnostics & Background Effects Analysis
docs/qa/GMEET-PARITY.md (lines 15)
Background effects entry expanded with detailed Phase A investigation results, FFmpegDemuxer codec limitations (H.264/AAC absence in standard CEF binary), and licensing/build-infra context for Chrome-branded distribution switch.
Sign-Off & Follow-Up Actions
docs/qa/GMEET-PARITY.md (lines 75–80)
Sign-off section updated with consolidated results, new dated entries, and explicit follow-up action items including references to CEF codec work and related tracked issues.

Estimated Code Review Effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 The codec mystery unfolds at last,
Phase A diagnostics light the path—
Chrome's codecs hide in H.264's embrace,
While diagnostics map the QA space.
Dynamic effects await their fix,
One line of bytes in binary mix! 🎬

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Linked Issues check ❓ Inconclusive The PR partially addresses issue #1223's technical requirements by documenting the codec-gap fix and acceptance criteria, but does not implement the actual CEF binary switch or verification—those remain pending operational tasks. Clarify whether this documentation PR fully satisfies #1223 acceptance criteria or if code-side implementation (CEF binary switch, verification tests) remains outstanding and tracked separately.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately references the main change: documenting codec-gap status after PR #1251 build infrastructure landed, directly tied to issue #1223.
Out of Scope Changes check ✅ Passed The PR contains only documentation updates to GMEET-PARITY.md aligned with issue #1223 and PR #1251 infrastructure work; no unrelated changes detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@senamakel senamakel merged commit 13d3ced into tinyhumansai:main May 6, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vendored CEF lacks proprietary codec support — Gmeet dynamic video backgrounds fail with FFmpegDemuxer error

2 participants