feat(settings): move Notification Routing into Developer Options

[graycyrus]

Summary

• Remove Notification Routing from the top-level settings menu (SettingsHome.tsx)
• Add it as a sub-item under Developer Options (DeveloperOptionsPanel.tsx)
• Update breadcrumb to read Settings > Developer Options > Notification Routing (useSettingsNavigation.ts)
• Move the <Route> declaration next to other Developer Options routes (Settings.tsx)

Test plan

• Unit test for useSettingsNavigation breadcrumbs (notification-routing, notifications, developer-options)
• Manual: Settings menu no longer shows Notification Routing at top level
• Manual: Developer Options → Notification Routing works and shows correct breadcrumb
• Manual: All existing Notification Routing functionality unchanged

Closes #1276

Summary by CodeRabbit

• Refactor
  • Reorganized the Settings menu structure by relocating "Notification Routing" to the Developer Options section.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a651e90d-d445-4b77-a2a4-069aff4b7c3f

📥 Commits

Reviewing files that changed from the base of the PR and between a3a1843 and dad2238.

📒 Files selected for processing (5)

• app/src/components/settings/SettingsHome.tsx
• app/src/components/settings/hooks/__tests__/useSettingsNavigation.test.tsx
• app/src/components/settings/hooks/useSettingsNavigation.ts
• app/src/components/settings/panels/DeveloperOptionsPanel.tsx
• app/src/pages/Settings.tsx

💤 Files with no reviewable changes (1)

• app/src/components/settings/SettingsHome.tsx

---

📝 Walkthrough

Walkthrough

This PR relocates the "Notification Routing" settings panel from the top-level settings menu to the Developer Options subsection. The menu item is removed from SettingsHome, added to DeveloperOptionsPanel, route definitions are reorganized, and breadcrumb logic is updated to reflect the new hierarchy.

Changes

Notification Routing Hierarchy Reorganization

Layer / File(s)	Summary
UI Menu Restructuring app/src/components/settings/SettingsHome.tsx, app/src/components/settings/panels/DeveloperOptionsPanel.tsx	"Notification Routing" item removed from top-level grouped menu in SettingsHome and added as a sub-item in DeveloperOptionsPanel with id, title, description, route, and SVG icon.
Routing & Breadcrumb Logic app/src/pages/Settings.tsx, app/src/components/settings/hooks/useSettingsNavigation.ts	Settings.tsx route definitions reordered; notification-routing route repositioned. useSettingsNavigation breadcrumb logic updated so notification-routing now resolves to "Settings > Developer Options" instead of "Settings" alone.
Tests app/src/components/settings/hooks/__tests__/useSettingsNavigation.test.tsx	New test file added with BreadcrumbProbe component and three test cases validating breadcrumb output for notification-routing, notifications, and developer-options routes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

• tinyhumansai/openhuman#494: Modifies the same settings navigation surface and adjusts breadcrumb/route handling.
• tinyhumansai/openhuman#1225: Moves settings subpages into Developer Options and updates Settings.tsx, DeveloperOptionsPanel, and useSettingsNavigation.
• tinyhumansai/openhuman#876: Touches Notification Routing settings UI and routing logic.

Suggested reviewers

• senamakel

Poem

🐰 A settings page gets neat and tidy,
Notification Routing finds a home inside-y,
Beneath Developer Options it now rests,
Less clutter for users—a true quest! ✨
Breadcrumbs guide the way through the fold. 🥕

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title accurately summarizes the main change: moving Notification Routing into Developer Options, matching the core objective.
Linked Issues check	✅ Passed	All acceptance criteria from issue #1276 are met: Notification Routing removed from top-level menu, added to Developer Options, breadcrumb updated, functionality preserved, and tests added.
Out of Scope Changes check	✅ Passed	All changes are within scope of issue #1276: menu restructuring, breadcrumb updates, route reorganization, and test additions for the new structure are all directly related to moving Notification Routing.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}