Skip to content

Feat/byoc aws deployment#1300

Closed
YellowSnnowmann wants to merge 7 commits intotinyhumansai:mainfrom
YellowSnnowmann:feat/byoc-aws-deployment
Closed

Feat/byoc aws deployment#1300
YellowSnnowmann wants to merge 7 commits intotinyhumansai:mainfrom
YellowSnnowmann:feat/byoc-aws-deployment

Conversation

@YellowSnnowmann
Copy link
Copy Markdown
Contributor

Summary

  • What changed and why.
  • Keep this to 3-6 bullets focused on user-visible or architecture-impacting changes.

Problem

  • What issue or risk this PR addresses.
  • Include context needed for reviewers to evaluate correctness quickly.

Solution

  • How the implementation solves the problem.
  • Note important design decisions and tradeoffs.

Submission Checklist

If a section does not apply to this change, mark the item as N/A with a one-line reason. Do not delete items.

  • Tests added or updated (happy path + at least one failure / edge case) per docs/TESTING-STRATEGY.md
  • Diff coverage ≥ 80% — changed lines (Vitest + cargo-llvm-cov merged via diff-cover) meet the gate enforced by .github/workflows/coverage.yml. Run pnpm test:coverage and pnpm test:rust locally; PRs below 80% on changed lines will not merge.
  • Coverage matrix updated — added/removed/renamed feature rows in docs/TEST-COVERAGE-MATRIX.md reflect this change (or N/A: behaviour-only change)
  • All affected feature IDs from the matrix are listed in the PR description under ## Related
  • No new external network dependencies introduced (mock backend used per docs/TESTING-STRATEGY.md)
  • Manual smoke checklist updated if this touches release-cut surfaces (docs/RELEASE-MANUAL-SMOKE.md)
  • Linked issue closed via Closes #NNN in the ## Related section

Impact

  • Runtime/platform impact (desktop/mobile/web/CLI), if any.
  • Performance, security, migration, or compatibility implications.

Related

  • Closes:
  • Follow-up PR(s)/TODOs:

AI Authored PR Metadata (required for Codex/Linear PRs)

Keep this section for AI-authored PRs. For human-only PRs, mark each field N/A.

Linear Issue

  • Key:
  • URL:

Commit & Branch

  • Branch:
  • Commit SHA:

Validation Run

  • pnpm --filter openhuman-app format:check
  • pnpm typecheck
  • Focused tests:
  • Rust fmt/check (if changed):
  • Tauri fmt/check (if changed):

Validation Blocked

  • command:
  • error:
  • impact:

Behavior Changes

  • Intended behavior change:
  • User-visible effect:

Parity Contract

  • Legacy behavior preserved:
  • Guard/fallback/dispatch parity checks:

Duplicate / Superseded PR Handling

  • Duplicate PR(s):
  • Canonical PR:
  • Resolution (closed/superseded/updated):

…mote coreToken support

- Restore core auth middleware is already correct in src/core/auth.rs (no change needed)
- Add docker/metadata-action + docker/build-push-action to release-production.yml build-docker job
  with semver, sha, and latest tags targeting ghcr.io/tinyhumansai/openhuman-core
- configPersistence: add getStoredCoreToken/storeCoreToken/clearCoreToken for remote deployment token
- coreRpcClient: getCoreRpcToken now checks getStoredCoreToken() first (remote mode),
  falling back to Tauri invoke (local mode); export clearCoreRpcTokenCache
- config: add REMOTE_CORE_RPC_MODE() function (reads localStorage) for remote-core detection;
  update CoreStateProvider call site to invoke as function
- deploymentsApi: replace with new BYOC AWS contract (provision/getStatus/getHealth/terminate
  + getCoreToken helper for /auth/me); typed DeploymentStatus, DeploymentInstance, etc.
- CloudInstancePanel: new settings panel with 4 views (no-instance/in-progress/active/failed),
  AWS credential form with IAM policy copy block, status polling, switch-to-remote/local,
  terminate with confirmation dialog
- Settings: wire CloudInstancePanel under /settings/cloud-instance with Infrastructure section
…sponse handling

- Replace apiClient calls with callCoreCommand for coreToken retrieval, provisioning, status, health checks, and termination.
- Introduce ApiEnvelope type for consistent response structure.
- Add unit tests for deploymentsApi to validate core RPC interactions and error handling.
- Introduced a new settings option for managing cloud instances, including an icon and description.
- Added navigation functionality to the Infrastructure settings page.
- Added support for "deployment" in namespace descriptions, providing details on cloud instance provisioning and status.
- Integrated deployment management controllers into the registered controllers and declared controller schemas.
… schemas

- Introduced a new `deployment` module for managing cloud deployments, including operations for provisioning, status checks, health checks, and termination.
- Added corresponding schemas for deployment operations, enhancing the API structure and documentation.
- Integrated new functions for handling deployment-related API calls and responses.
…ode formatting

- Removed redundant imports and organized the import statements in CloudInstancePanel.
- Enhanced readability by formatting SVG elements and restructuring the deployment status array for clarity.
- Updated Settings page to correctly import CloudInstancePanel after refactoring.
…r clarity

- Added missing import for buildRpcEndpoint and organized existing imports in CloudInstancePanel.
- Improved code structure to enhance readability and maintainability.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 6, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8755a096-7bb0-4429-9684-f2d50b6918d6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands and usage tips.

@senamakel
Copy link
Copy Markdown
Member

closing this as we discussed. this is too complicated. focus on a simpler solution

@senamakel senamakel closed this May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants