Update README, correct outdated 'usage' instructions, fix: #100 #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singlerider
force-pushed
the
update-readme
branch
from
0bc3652 to
e6f0fb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation (Problem vs. Solution)
As described in #100, there is no explanation in the repository how to "properly" save the API keys without following bytes (including a
\newline character). This brings the instructions up-to-date with what is found at https://docs.turnkey.com/sdks/cli#add-your-public-api-key. These changes also get rid of the outdated/api/v1/signinstructions that are no longer pointing to live endpoints.Release Steps
See README for additional details.