Skip to content

mt76: mt76_connac: set is_mt7902 inside is_mt7921#13

Open
hmtheboy154 wants to merge 1 commit into
tnguy3333:mainfrom
hmtheboy154:connac
Open

mt76: mt76_connac: set is_mt7902 inside is_mt7921#13
hmtheboy154 wants to merge 1 commit into
tnguy3333:mainfrom
hmtheboy154:connac

Conversation

@hmtheboy154
Copy link
Copy Markdown

So we don't have to set is_mt7902 everytime we see is_mt7921. Which will help us inherit all of common mt792x codes like mt7920 & mt7922.

So we don't have to set is_mt7902 everytime we see is_mt7921. Which will
help us inherit all of common mt792x codes like mt7920 & mt7922.

Signed-off-by: hmtheboy154 <buingoc67@gmail.com>
@dubhater
Copy link
Copy Markdown

What if some function needs to do one thing for 7921 and something else for 7902?

@hmtheboy154
Copy link
Copy Markdown
Author

hmtheboy154 commented Aug 28, 2025

What if some function needs to do one thing for 7921 and something else for 7902?

Beside TX/RX handling & firmware handling, I think we can inherit all of 7921 code. On the Android BSP code it actually show that 7902 inherit a lot from 7921 (like 7922) to the point that you can see things like this:
https://github.com/MiCode/MTK_kernel_modules/blob/bsp-rodin-v-oss/connectivity/wlan/core/gen4-mt79xx/chips/mt7961/mt7961.c#L60
https://github.com/MiCode/MTK_kernel_modules/blob/bsp-rodin-v-oss/connectivity/wlan/core/gen4-mt79xx/include/chips/mt7961.h#L57
https://github.com/MiCode/MTK_kernel_modules/blob/bsp-rodin-v-oss/connectivity/wlan/core/gen4-mt79xx/chips/mt7961/hal_wfsys_reset_mt7961.c#L59

And firmware handling differences is just because mt7902 have support for Zigbee so it need an extra switch for BT/Zigbee which mean we only need RX/TX handling which I sorta did at #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants