Adding proxies optional argument#44
Open
Varin6 wants to merge 1 commit intotoby-p:masterfrom
Open
Conversation
Owner
|
Apologies for the delay! I'm not clear on why this is necessary so hesitant to just implement it. Could you explain why/when it's needed? Would it be better to just allow any kwargs for Also please clarify if it also needs to be added to this line: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed to use proxies for requests and added an optional argument to pass in when initializing
RightmoveData.If you don't want to use proxies - nothing changes, if you do, the init looks like this:
rm = RightmoveData(url, False, proxies)where proxies are a dict: