Make changes required by having pandas>3.0.0#55
Open
david-mears-2 wants to merge 1 commit intotoby-p:masterfrom
Open
Make changes required by having pandas>3.0.0#55david-mears-2 wants to merge 1 commit intotoby-p:masterfrom
david-mears-2 wants to merge 1 commit intotoby-p:masterfrom
Conversation
One for this: https://pandas.pydata.org/pandas-docs/stable/user_guide/copy_on_write.html And one to avoid triggering pandas' now-more-strict type checking to throw an error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to run rightmove_webscraper using the version of pandas in requirements.txt didn't work. So instead I update the version of pandas.
One change was for this: https://pandas.pydata.org/pandas-docs/stable/user_guide/copy_on_write.html
And one change was to avoid triggering pandas' now-more-strict type-checking to throw an error.
Note that you won't get as far as triggering pandas-caused errors unless you first incorporate the fixes in #54.