sqm: gate USE_MQ after loading the selected qdisc script#184
Open
pesa1234 wants to merge 1 commit intotohojo:mainfrom
Open
sqm: gate USE_MQ after loading the selected qdisc script#184pesa1234 wants to merge 1 commit intotohojo:mainfrom
pesa1234 wants to merge 1 commit intotohojo:mainfrom
Conversation
start-sqm sources defaults.sh before the selected *.qos script, so SUPPORT_MQ is not yet set at that point. This can force USE_MQ=0 even for scripts that declare SUPPORT_MQ=1 (e.g. piece_of_cake.qos). Move the SUPPORT_MQ gate to start-sqm after loading the selected script, and keep per-interface cake_mq selection in select_cake(). Signed-off-by: Andrea Pesaresi <andreapesaresi82@gmail.com>
pesa1234
force-pushed
the
fix-fallback-cake
branch
from
cec6477 to
472fe76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
start-sqm sources defaults.sh before the selected *.qos script, so SUPPORT_MQ is not yet set at that point. This can force USE_MQ=0 even for scripts that declare SUPPORT_MQ=1 (e.g. piece_of_cake.qos).
Move the SUPPORT_MQ gate to start-sqm after loading the selected script, and keep per-interface cake_mq selection in select_cake().
I alreay see an other PR #183
So, feel free to close this one in any case is redundant
Run tested on openwrt snapshot with Gl.inet MT6000