refactor: centralize branch tracing into BranchTracing helper#3539
Draft
dkrizan wants to merge 1 commit intobdshadow/add-tracing-to-branchingfrom
Draft
refactor: centralize branch tracing into BranchTracing helper#3539dkrizan wants to merge 1 commit intobdshadow/add-tracing-to-branchingfrom
dkrizan wants to merge 1 commit intobdshadow/add-tracing-to-branchingfrom
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Instead of scattering Span.current().setAttribute() calls and private set*TracingAttributes() methods across each branch service, introduce a shared BranchTracing component with one high-level method per operation type (traceCopy, traceDryRunMerge, traceApplyMerge, etc.). Services now need only a single tracing call per method. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
a8c6c4e to
c602761
Compare
Contributor
|
This PR is stale because it has been open for 30 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Alternative approach to the tracing attribute-setting in #3464 — as discussed in this review comment.
Instead of scattering
Span.current().setAttribute()calls andprivate fun set*TracingAttributes()methods in each service, this introduces a sharedBranchTracingcomponent with one high-level method per operation type.What changes:
BranchTracingcomponent inbackend/datawith typed, explicit methods:traceCopy(),traceDryRunMerge(),traceApplyMerge(),traceCreateBranch()TolgeeTracingContextinjection needed in services (onlyBranchTracing)private fun set*TracingAttributes()helper methods removed from services@WithSpanannotations kept as-isBefore (current PR):
After:
Test plan
@WithSpancreates spans as before