Conversation
| // this up() migration is auto-generated, please modify it to your needs | ||
| $this->abortIf($this->connection->getDatabasePlatform()->getName() !== 'mysql', 'Migration can only be executed safely on \'mysql\'.'); | ||
|
|
||
| $this->addSql('ALTER TABLE entry CHANGE url url VARCHAR(2048) NOT NULL'); |
There was a problem hiding this comment.
this was more or less a performance consideration, since this field holds an important unique index and keeping that to a sane size seemed prudent, but since I never experienced any bottlenecks in this area, I guess we can up this
There was a problem hiding this comment.
It should be increased for using long urls, IE git 2048 and the most other browser more...
There was a problem hiding this comment.
yes, I agree - please re-read my comment 😄
There was a problem hiding this comment.
I´ll fix in with a new pr
|
since you decided to put so many changes in one PR, you will have to live with me dissecting this very tedious - having small PRs would make both of our lives much easier 😄 |
| * bin/console fo:us:cr (follow the steps) | ||
| Prerequirements: Vagrant installed, Virtualbox installed, Ansible installed | ||
|
|
||
| * ```vagrant up``` |
There was a problem hiding this comment.
does this even render in Markdown? some combination of inline code block and fenced code block? to see what I was talking about? https://raw.githubusercontent.com/tolry/talkly/master/README.md
| @@ -0,0 +1,23 @@ | |||
| parameters: | |||
There was a problem hiding this comment.
you will need to change
Line 41 in b0391a9
To make travis use this file, Scrutinizer is configured within scrutinizer, I think - will have to check
There was a problem hiding this comment.
scrutinizer automatically uses parameters.dist.yml, see https://scrutinizer-ci.com/g/tolry/mental-note/inspections/d8c5ac24-1fe8-4334-a5ea-a26616bb512c/log
sed -i 's/database_host: .*/database_host: 127.0.0.1/' app/config/parameters.yml.dist
so I would really prefer keeping the dist.yml as template as well as for the tests (travis, scrutinizer) and your setup using a different file or seding your settings or similar
2 participants
A mental note vagrant/ansible development enviroment