-
Notifications
You must be signed in to change notification settings - Fork 31
feat(ci): revamp JSX-in-MDX formatting and add /fmt command for maintainers
#1263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
novusnota
wants to merge
20
commits into
main
Choose a base branch
from
closes-1006/dispatch-the-fmt
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
/fmt command for maintainersb583b0c to
7fc1c50
Compare
7fc1c50 to
b200b16
Compare
This comment has been minimized.
This comment has been minimized.
novusnota
commented
Dec 11, 2025
novusnota
commented
Dec 11, 2025
/fmt command for maintainers
/fmt command for maintainers/fmt command for maintainers
/fmt command for maintainers/fmt command for maintainers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No documentation issues detected.
novusnota
commented
Dec 11, 2025
novusnota
commented
Dec 11, 2025
novusnota
commented
Dec 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No documentation issues detected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1006
Towards #1352
This PR:
commander.ymlworkflow, which is meant to respond to comments. Currently, it can respond to/fmtcomments by creating a new commit that applies formatting (npm run fmt:some) to the .mdx and .md files changed in this PR. Notice that it will only react to maintainers and only do work in direct branches.Now, regarding forks, you can read the prior notes or review the commit history, but in short, they are very tough to manage. New commits are often not possible to make without author's discretion, and sending automated review changes is also somewhat error-prone (we do it for our AI pipeline, but the formatter is another story), not to mention the need to secure the dependencies and scripts from various malicious uses.
What we can do, as
@Danil42Russiamentioned, is set up https://autofix.ci and run it either on forks or on regular PRs, but only after they are open for review — to avoid hindering the iterative work processes otherwise. For that, someone with higher access to this repository should add it.Prior notes
Things to try:
UPD: After some testing, I know that:
check_runalways runs from the base (likepull_request_target), so merge was required. That said, it did not help eitherAlso, commits in forks are a massive issue for some reason. We might just use autofix.ci for forks specifically and forget about it.