Feature/custom model editor by ditschi · Pull Request #426 · toniebox-reverse-engineering/teddycloud

ditschi · 2026-03-09T21:44:33Z

This Adds

tonies.custom.json save API with validation and backups
custom_img root support for image workflows
image cache improvement - now images are not broken when cache is disabled
Dev-Sandbox -- local setup to emulate teddycloud with content

~~I also removed built web assets from teddycloud_web submodule -- i assume that was added by accident?!)~~

REQUIRED BY: Web changes from toniebox-reverse-engineering/teddycloud_web#283

Dev Sandbox

Added Dev sandbox that can be used locally to check changes made in the web ui. The Sandbox adds several custom tonies, models, images ad audio files

Preview -- what will these backend changes make available in web

Custom Tonies Editor: Editor for managing custom tonie models

Settings: Enable/Disable Editor -- (changes menu entry from WIP: Add Model to Manage custom models

Custom tonies editor Manage custom models

Image Manager:

Shared UI for selecting and managing images in TeddyStudio and Custom Tonies Editor

Image Editor::Default Images

Image Editor::Upload and manage Custom Images -- also available in Tonie Studio

SciLor · 2026-03-09T21:55:08Z

Please use the web repo for the web stuff.

ditschi · 2026-03-09T22:16:15Z

Please use the web repo for the web stuff

Sure .. Second PR will be created for submodule changes

…anagement - Backend: tonies.custom.json save API with validation and backups - Backend: custom_img root support for image workflows - Frontend: Full editor for custom models (add, edit, delete) - Frontend: Image picker and file browser integration - Remove built web assets (now built from teddycloud_web submodule)

SciLor · 2026-03-10T05:46:52Z

Please also remove the compiled web changes (contrib www)
This will be done later by the pipeline.

henryk86 · 2026-03-10T18:23:26Z

This would solve the following issues:

- Remove custom_editor_preview setting (editor always active) - Ignore contrib/data/www/ (compiled web assets) - Update teddycloud_web submodule (v0.7.0, PR feedback) Made-with: Cursor

ditschi · 2026-03-11T00:05:17Z

Please also remove the compiled web changes (contrib www) This will be done later by the pipeline.

removed and added to .gitignore.

- Added ca-certificates to the list of packages installed in the build environment.

…elop

ditschi · 2026-03-16T23:12:50Z

This helped me really much ti develop new features. On the other hand I am not happy about adding binaries to the repo although they are small.

I f not wented ti can werork my history to remove al binary blobs again. However for useabilety during development it might be worth to keep this.

Also this couldbe used to start up a demo instance users can check out?!

This helped me really much ti develop new features. On the other hand I am not happy about adding binaries to the repo although they are small.
You mean the TAFs and the images? You can keep them in the repo, if those are free to use. The images look AI-generated. Are the TAFs, too?

Also this couldbe used to start up a demo instance users can check out?!
I don't think this makes sense. This will end up in a mess. People will start to attack this instance, fill it with copyright material etc.

Images are AI, created by me. i assume they are therefore free to use? I at least hereby confirm that everybody can use them ans Attribution-NonCommercial-ShareAlike.

Taf: i struggled to find a really short audio. I ended up using the ICQ message tone that is free to download on a vast amount of pages. All taf are that audio (but wit modified header to have different ID and hashes) -- i guess you have a point there. This probably is a copyright issue.

Ill rework, remove from history and try to find alternative.

https://github.com/toniebox-reverse-engineering/hackiebox_cfw/tree/master/audio
This may help

already had found https://pixabay.com/sound-effects/musical-comedy-stinger-quick-joke-cue-469097/).

that is now used. sadly somehow the header replacement did not work as expected so i need to investigate my custom models in dev-sandbox tomorrow

SciLor · 2026-03-17T07:00:54Z

Please reset the deletions you did in "contrib/data/www/‎". This means, use the files in the current develop. Also please reset the submodule teddycloud_web to the one in develop.

- Introduced a new `dev-sandbox` directory for running TeddyCloud with mock data. - Added Docker support for local development, including setup and teardown scripts. - Included configuration files and sample data for testing. - Updated `.gitignore` to exclude sandbox runtime data. - Enhanced README with instructions for using the development sandbox. - Use free audio content for audio_*.taf (source: https://pixabay.com/sound-effects/musical-comedy-stinger-quick-joke-cue-469097/).

- Added functions to resolve cached URLs to original URLs when cache is disabled. - Implemented cache entry creation for redirects based on index lookup. - Updated cache handling in the server to utilize the persistent index for missing entries. - Enhanced JSON handling to persist original URLs instead of cached paths for image loading.

…oad timeout - Restore contrib/data/www/ from develop - Reset teddycloud_web submodule to develop - Add core.file_upload_timeout_ms

- Replaced the old `docker-compose.test.yaml` with a new `docker-compose.yaml` for simplified Docker setup. - Introduced a new `Dockerfile` for building the development environment with necessary dependencies. - Updated `Makefile` to reflect changes in Docker commands and improve output formatting. - Modified `setup.sh` to ensure proper directory structure and file copying for the sandbox. - Updated `README.md` with clearer usage instructions for the development sandbox. - Adjusted JSON configuration files for tonies to ensure correct audio source references. - Added new content JSON files for additional tonies models.

…heck words

SciLor · 2026-03-24T06:26:33Z

Could you give me a brief description, what the caching changes do exactly and which problem you solved?

ditschi · 2026-03-27T11:23:54Z

Could you give me a brief description, what the caching changes do exactly and which problem you solved?

From now on we Store mapping from Cached image path to original URL (tab separatd file). When cache is enabled the backend uses that to serve the correct file from cache. When saving a model we always store the url, that way if you lose your cache, the images can't still be ob change (and the cache can be recreated).

In case production environment misses to back up the cache dir (which I did 🤦 ) you should be able to recover.

henryk86 · 2026-03-27T11:54:15Z

Could you give me a brief description, what the caching changes do exactly and which problem you solved?

From now on we Store mapping from Cached image path to original URL (tab separatd file). When cache is enabled the backend uses that to serve the correct file from cache. When saving a model we always store the url, that way if you lose your cache, the images can't still be ob change (and the cache can be recreated).

In case production environment misses to back up the cache dir (which I did 🤦 ) you should be able to recover.

Shouldn’t be the lost images be automatically fetched and cached again? Is that not already implemented?

SciLor · 2026-04-04T11:46:34Z

Please split the cache changes from the custom model editor changes, as this currently blocks the merge.

ditschi · 2026-04-07T19:19:24Z

After looking into this after my vaccation more carefully, I realize my earlier answer was inaccurate -- I had misunderstood how the existing cache works.

The cache is already robust by design: it uses a deterministic SHA256 hash of the original URL as the filename, and the JSON files (tonies.json, tonies.custom.json).

My original issue was caused by my web logic for custom models. Here I did not always store the original URL in the custom.json but sometimes the image selector returned the /cache/... path. This is a bug and I will update the web PR to always use the original URL and to never over cache paths in the image selector.

My cache changes (persistent index, fallback resolution) therefore were essentially an unnecessary safety net based on a wrong assumption that /cache/... paths could end up persisted in the JSON. I'm removing them from this PR entirely and have updated the frontend to not rely on cachePic at all. No separate cache PR needed.

SciLor · 2026-04-09T18:43:19Z

The build fails, maybe some change in the makefile is problematic

ditschi · 2026-04-10T17:31:52Z

The build fails, maybe some change in the makefile is problematic

I will have a look at this later -- on my machine it worked in the Devcontainer 😜

ditschi force-pushed the feature/custom-model-editor branch 2 times, most recently from 4a44e68 to 0127d1e Compare March 9, 2026 22:14

ditschi mentioned this pull request Mar 9, 2026

feat: Custom models editor with image picker and file browser integration toniebox-reverse-engineering/teddycloud_web#283

Merged

ditschi force-pushed the feature/custom-model-editor branch from 0127d1e to 95b2482 Compare March 9, 2026 22:33

henryk86 reviewed Mar 10, 2026

View reviewed changes

Comment thread src/settings.c Outdated

feat: Custom Models Editor integration

f719ae3

- Remove custom_editor_preview setting (editor always active) - Ignore contrib/data/www/ (compiled web assets) - Update teddycloud_web submodule (v0.7.0, PR feedback) Made-with: Cursor

ditschi force-pushed the feature/custom-model-editor branch from c738c7d to 68eef21 Compare March 11, 2026 00:22

fix: git push now works in devcontaier

d796621

- Added ca-certificates to the list of packages installed in the build environment.

ditschi force-pushed the feature/custom-model-editor branch from 68eef21 to d796621 Compare March 11, 2026 00:25

SciLor reviewed Mar 11, 2026

View reviewed changes

Comment thread .gitignore Outdated

fix: remove contrib/data/www from .gitignore, revert submodule to dev…

b0eb59c

…elop

ditschi force-pushed the feature/custom-model-editor branch from 46294f0 to 14465ee Compare March 16, 2026 21:45

ditschi commented Mar 16, 2026

View reviewed changes

ditschi marked this pull request as ready for review March 16, 2026 23:13

ditschi force-pushed the feature/custom-model-editor branch 4 times, most recently from 681e292 to 689ce65 Compare March 17, 2026 20:14

SciLor reviewed Mar 18, 2026

View reviewed changes

Comment thread src/settings.c Outdated

SciLor reviewed Mar 18, 2026

View reviewed changes

Comment thread include/settings.h Outdated

Christian Ditscher added 3 commits March 19, 2026 20:49

address PR review: restore contrib/www, reset submodule, add file upl…

d06ff0e

…oad timeout - Restore contrib/data/www/ from develop - Reset teddycloud_web submodule to develop - Add core.file_upload_timeout_ms

SciLor marked this pull request as draft March 23, 2026 09:58

ditschi force-pushed the feature/custom-model-editor branch from 689ce65 to 039c5a9 Compare March 23, 2026 19:44

address PR review feedback, add dockerignore, and update local spellc…

666f1dc

…heck words

ditschi marked this pull request as ready for review March 23, 2026 20:08

SciLor marked this pull request as draft April 4, 2026 11:45

refactor: remove cache-index fallback changes

366f067

ditschi marked this pull request as ready for review April 7, 2026 19:20

SciLor merged commit 57b436a into toniebox-reverse-engineering:develop Apr 9, 2026
3 of 27 checks passed

SciLor mentioned this pull request Apr 9, 2026

Revert "Feature/custom model editor" #433

Merged

ditschi mentioned this pull request Apr 10, 2026

Reapply: Custom model editor (fix Docker build) #434

Merged

Conversation

ditschi commented Mar 9, 2026 • edited by SciLor Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

This Adds

Dev Sandbox

Preview -- what will these backend changes make available in web

Custom Tonies Editor: Editor for managing custom tonie models

Image Manager:

Uh oh!

SciLor commented Mar 9, 2026

Uh oh!

ditschi commented Mar 9, 2026

Uh oh!

SciLor commented Mar 10, 2026

Uh oh!

henryk86 commented Mar 10, 2026

Uh oh!

Uh oh!

ditschi commented Mar 11, 2026

Uh oh!

Uh oh!

ditschi Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

SciLor Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

ditschi Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

SciLor Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

ditschi Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

SciLor commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SciLor commented Mar 24, 2026

Uh oh!

ditschi commented Mar 27, 2026

Uh oh!

henryk86 commented Mar 27, 2026

Uh oh!

SciLor commented Apr 4, 2026

Uh oh!

ditschi commented Apr 7, 2026

Uh oh!

Uh oh!

SciLor commented Apr 9, 2026

Uh oh!

ditschi commented Apr 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ditschi commented Mar 9, 2026 •

edited by SciLor

Loading

SciLor commented Mar 17, 2026 •

edited

Loading