fix: WSL terminal profile icons#5
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8b17bfeca9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
This PR adjusts how terminal profile icons are chosen for Command Palette rendering by filtering Windows Terminal icon values down to glyph/emoji-safe strings, and adds WSL detection to prefer a penguin fallback. It also centralizes several context-menu icons into shared glyph constants.
Changes:
- Add
TerminalProfileIconResolver.IsCmdPalGlyphIcon()to reject file/URI icon values that CmdPal can’t render. - Update
TerminalLaunchGlyphsto detect WSL profiles and use the Linux penguin fallback, and to only accept glyph/emoji profile icons. - Replace several hard-coded context-menu glyphs with
ShortcutGlyphsconstants and add targeted tests.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| QuickShell/Services/ShortcutContextCommands.cs | Switch context-menu icons to shared glyph constants (and updates companion app icon selection). |
| QuickShell/Commands/WorkspaceUtilityCommands.cs | Switch command icons to shared glyph constants (and updates companion app icon selection). |
| QuickShell.Core/Services/TerminalProfileIconResolver.cs | Add CmdPal-specific glyph/emoji validation helper for icon strings. |
| QuickShell.Core/Services/TerminalLaunchGlyphs.cs | Skip non-glyph icons for CmdPal and treat WSL profiles as Linux penguin. |
| QuickShell.Core/Services/ShortcutGlyphs.cs | Add new shared glyph constants used by updated commands/menus. |
| QuickShell.Core.Tests/TerminalProfileIconResolverTests.cs | Add tests for the new glyph-icon filter and WSL fallback behavior. |
Add CompanionAppCatalog.GetContextMenuIcon, remove unresolved IconInfo cref, and resolve WT profiles once per glyph lookup. Co-authored-by: Cursor <cursoragent@cursor.com>
Use penguin glyph for WSL profiles when WT PNG icons are unavailable, resolve profile icons once per lookup, parse WSL --distribution in command lines, and add terminal launch test seam. Co-authored-by: Cursor <cursoragent@cursor.com>
tonythethompson
changed the base branch from
pr/extract-shortcut-launch-executor
to
master
tonythethompson
force-pushed
the
pr/wsl-terminal-profile-icons
branch
from
bfc67ff to
4f86998
Compare
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Summary
Test plan