feat: companion app and dev-server discovery#6
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6ae11b74d8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
This PR expands workspace “companion app” discovery (editor/IDE selection) and improves workspace seeding by inferring dev-server URLs, launch commands, and basic workspace health/metadata signals.
Changes:
- Adds companion-app preset catalog entries and directory-based inference signals (VS/JetBrains/Zed/Sublime/Obsidian/git).
- Introduces Visual Studio + JetBrains install discovery helpers and enhances companion-app argument expansion (
{solution}). - Adds dev launch-command detection from
package.jsonand improves workspace list health messaging.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| QuickShell.Core/Services/WorkspaceSeedFactory.cs | Seeds workspaces with inferred dev-server URL and launch command hints. |
| QuickShell.Core/Services/WorkspaceCompanionSignals.cs | Adds filesystem signals for inferring project/editor type (sln, .idea, etc.). |
| QuickShell.Core/Services/VisualStudioInstallDiscovery.cs | Adds Visual Studio discovery via vswhere.exe and devenv path preset inference. |
| QuickShell.Core/Services/ShortcutHealth.cs | Improves subtitle messaging and flags missing companion app installations. |
| QuickShell.Core/Services/JetBrainsInstallDiscovery.cs | Adds JetBrains Rider/IntelliJ install discovery heuristics. |
| QuickShell.Core/Services/DevServerUrlDetection.cs | Adds package.json-based dev launch command detection and package-manager selection. |
| QuickShell.Core/Services/CompanionAppLauncher.cs | Expands companion app arguments with {solution} token support. |
| QuickShell.Core/Services/CompanionAppDetection.cs | Expands companion-app suggestions to more editors/IDEs and adds preset priority. |
| QuickShell.Core/Services/CompanionAppCatalog.cs | Adds many new presets, reconciliation helpers, and context menu icons. |
| QuickShell.Core/Models/TerminalShortcut.cs | Updates dev-server URL documentation to match new behavior. |
| QuickShell.Core.Tests/ShortcutDisplayTests.cs | Adds a glyph assertion test for copy-path icon. |
Sync detected dev commands into launch entries, search JetBrains Toolbox build dirs, drain vswhere streams, list all companion presets in the form, and add regression tests. Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0786ba2f42
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: de352d5641
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
tonythethompson
force-pushed
the
pr/wsl-terminal-profile-icons
branch
from
bfc67ff to
4f86998
Compare
Expand companion app presets, detect workspace signals for IDE and git client suggestions, auto-detect dev server URLs and launch commands, and integrate JetBrains Toolbox and Visual Studio install discovery. Co-authored-by: Cursor <cursoragent@cursor.com>
tonythethompson
force-pushed
the
pr/companion-app-discovery
branch
from
6c4f791 to
de26342
Compare
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
tonythethompson
changed the base branch from
pr/wsl-terminal-profile-icons
to
master
Summary
Test plan