Refactor Mooncake Store: force delete + hard pin#73
Draft
cicirori wants to merge 1 commit intotorchspec-project:mainfrom
Draft
Refactor Mooncake Store: force delete + hard pin#73cicirori wants to merge 1 commit intotorchspec-project:mainfrom
cicirori wants to merge 1 commit intotorchspec-project:mainfrom
Conversation
cicirori
force-pushed
the
refactor/mooncake-force-delete
branch
9 times, most recently
from
6868f09 to
359133a
Compare
Replace DeferredDeleteManager with batch_remove(force=True) for immediate cleanup after consumption. Add hard_pin support (default off, pending Mooncake release). - Use batch_remove(force=True) in remove_eagle3_tensors() with retry - Add _verify_force_delete() fail-fast for Mooncake >= 0.3.10.post1 - Add _build_replicate_config() for ReplicateConfig(with_hard_pin=True) - Pass replicate_config through AsyncPutManager and sync put paths - Delete deferred_delete.py entirely - Add enable_hard_pin config with export_env/from_env/from_flat_args - Remove unused enable_soft_pin config field - Pin mooncake-transfer-engine >= 0.3.10.post1 in pyproject.toml - Error cleanup in put paths uses batch_remove(force=True) with try/except - Add 18 unit tests with conftest.py mock finder for torch-less envs Closes torchspec-project#72
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Closes #72