Fix issues + update readme#1
Open
MinmoTech wants to merge 7 commits intotoroidal-code:masterfrom
Open
Conversation
The url to access albums seems to have changed in the meantime from "albums" to "AL"
Features (feat.) don't get included in album arists anymore (Hatsune Miku is not an album artist). Multiple album artists are separated with a semicolon now, which most software prefers. Various artists -> Various Artists, to conform with the musicbrainz standard
In some albums like https://vocadb.net/Al/18564 there are songs which do not contain enough information to get processed by this plugin. This resulted in no results being returned. Now instead it returns a dummy_title, so the plugin doesn't fail at least
Also make english the default language to be used for titles
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fixed some issues and updated the readme, the commit messages should explain the individual changes