Support cursor pagination for fetching requestIdentifiers#533
Open
anotherminh wants to merge 7 commits intomainfrom
Open
Support cursor pagination for fetching requestIdentifiers#533anotherminh wants to merge 7 commits intomainfrom
anotherminh wants to merge 7 commits intomainfrom
Conversation
alexajury
approved these changes
Mar 4, 2026
added 5 commits
March 4, 2026 15:58
iamtheluckyest
approved these changes
Mar 6, 2026
| input: { | ||
| requestIds: $requestIds | ||
| input: { requestIds: $requestIds } | ||
| filterBy: { |
Member
There was a problem hiding this comment.
was this even working before with those values in input? 😅
| offset += PAGE_SIZE; | ||
| shouldContinue = nodes.length === PAGE_SIZE; | ||
| } while (shouldContinue); | ||
| cursor = pageInfo.endCursor ?? undefined; |
Member
There was a problem hiding this comment.
nit: I think calling this var endCursor would be clearer.
Comment on lines
+136
to
+150
| let requestsWithRequestIdentifiers: ExportedPrivacyRequest[]; | ||
| if (skipRequestIdentifiers) { | ||
| requestsWithRequestIdentifiers = requests.map((request) => ({ | ||
| ...request, | ||
| requestIdentifiers: [] as RequestIdentifier[], | ||
| })); | ||
| } else { | ||
| const identifiersByRequest = await fetchRequestIdentifiersBatch(sombra, { | ||
| requestIds: requests.map((r) => r.id), | ||
| }); | ||
| requestsWithRequestIdentifiers = requests.map((request) => ({ | ||
| ...request, | ||
| requestIdentifiers: identifiersByRequest.get(request.id) ?? [], | ||
| })); | ||
| } |
Member
There was a problem hiding this comment.
nit: I think this might be easier to read:
const identifiersByRequest = skipRequestIdentifiers
? new Map()
: await fetchRequestIdentifiersBatch(sombra, {
requestIds: requests.map((r) => r.id),
});
const requestsWithRequestIdentifiers = requests.map((request) => ({
...request,
requestIdentifiers: identifiersByRequest.get(request.id) ?? [],
}));
}
Comment on lines
+196
to
+212
| let enriched: ExportedPrivacyRequest[]; | ||
| if (skipRequestIdentifiers) { | ||
| enriched = nodes.map((n) => ({ | ||
| ...n, | ||
| requestIdentifiers: [], | ||
| })); | ||
| } else { | ||
| const identifiersByRequest = | ||
| await fetchRequestIdentifiersBatch(sombra!, { | ||
| requestIds: nodes.map((n) => n.id), | ||
| }); | ||
| enriched = nodes.map((n) => ({ | ||
| ...n, | ||
| requestIdentifiers: | ||
| identifiersByRequest.get(n.id) ?? [], | ||
| })); | ||
| } |
Member
There was a problem hiding this comment.
same suggestion for refactor here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Security Implications
[none]
System Availability
[none]