Skip to content

Conversation

@kvz
Copy link
Member

@kvz kvz commented Dec 16, 2025

No description provided.

@kvz kvz merged commit c5d5e14 into main Dec 16, 2025
10 checks passed
@kvz kvz deleted the sync-alphalib-2025-12-15 branch December 16, 2025 15:19
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines 74 to 76
export const interpolatableRobotImageGenerateInstructionsSchema = interpolateRobot(
robotImageGenerateInstructionsSchema,
robotImageGenerateInstructionsWithHiddenFieldsSchema,
)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep hidden image/generate fields out of public schema

The public interpolatableRobotImageGenerateInstructionsSchema now interpolates robotImageGenerateInstructionsWithHiddenFieldsSchema, which includes hidden provider/result fields. Because robotsSchema is built from this interpolatable schema, those hidden fields are now accepted in the public API where they were previously rejected, unintentionally expanding the contract and allowing callers to set internal-only fields. Switch back to interpolating the non-hidden schema so the public surface remains unchanged.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants