Add a dummy app to simulate get_env calls#64
Conversation
javiermtorres
force-pushed
the
test/simulate_app
branch
2 times, most recently
from
05b718c to
8ee0727
Compare
javiermtorres
force-pushed
the
test/simulate_app
branch
from
8ee0727 to
f0e6c28
Compare
RoadRunnr
left a comment
RoadRunnr
left a comment
There was a problem hiding this comment.
so much effort just to be able to use application:get_env/1 instead of application:get_env/2 ???
There is no explicit note on the intended use of application:get_env/1 in the documentation, but from checking the OTP applications and the source of application, I get the impression that the /1 variant is intended for libraries that want to read the environment of the calling application without having to know what that application is.
This project is clearly not a library and it knows exactly which application environment it wants to read or write to. I therefore see no value in adding the complexity to the test to simulate an application. Just use application:get_env(capwap, Value) everywhere and be done with it.
|
It's already done. |
3 participants
No description provided.