test(cli): cover main.rs command internals and publish/sync helpers (#638 pass 2)#663
Merged
Merged
Conversation
Second focused pass at #638's main.rs coverage gap: - bundle inspect/register JSON summary branches via the canonical expedition bundle fixture - capability publish guards: private-scope and non-JSON contract rejection, unsafe registry path segments, artifact digest read failure and happy path - registry_sync_failure_json stable shape - register_generated_app_bundle missing-manifest and incomplete-bundle guards - browser-adapter serve bind-address parse forms - curl_text fetch-failure surface (unreachable host) - RealPublishProcessRunner stdout capture, non-zero exit, and spawn failure - dirty-registry-checkout publish block Measured traverse-cli coverage 86.85% (up from 86.12%); threshold stays 86 to keep CI headroom. Remaining passes tracked on #638. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Second focused pass at #638 (
main.rscoverage), targeting command internals and publish/sync helpers with 8 new tests:inspect_bundle/register_bundleJSON summary branches via the canonical expedition bundle fixture./../separators), artifact digest read failure and happy pathregistry_sync_failure_jsonstable error shaperegister_generated_app_bundlemissing-manifest and incomplete-bundle (empty components) guardsbrowser-adapter servebind-address parse forms (default,--bind, malformed)curl_textfetch-failure surface against an unreachable hostRealPublishProcessRunner: stdout capture, non-zero exit status, and spawn failurecapability publishMeasured traverse-cli coverage 86.85% (up from 86.12%). The
ci/coverage-targets.txtthreshold stays at 86 — 0.15 headroom over 87 is too thin for CI variance; the next pass raises it. Remainingmain.rswork stays tracked on #638.Refs #638.
Governing Spec
033-http-json-api046-public-cli-app-registration056-capability-publishTest-only change; no behavior change (
no-spec-neededlabel on #638).Project Item
Issue #638 — Project 1 item
PVTI_lADOEbiBt84Bbyp1zgyjFKs(Status: In Progress, labelagent:claude)Validation
cargo test -p traverse-cli— all green (288 bin tests including the 8 new ones)cargo clippy --workspace --all-targets— clean;cargo fmt --check— cleanscripts/ci/coverage_gate.sh— traverse-cli 86.85% (14937/17198) against the 86 threshold; contracts/registry/runtime 100%, mcp 98.92%🤖 Generated with Claude Code