Open
Conversation
svenfuchs
force-pushed
the
sf-instrumentation
branch
2 times, most recently
from
bfd9133 to
129c18b
Compare
This seems completely broken in AR 4.2. Instead of setting up
configuration here, and then using a symbol for establishing the
connection ... we can just use the config hash in user space like
so:
[Log, Log::Part].each do |const|
const.establish_connection(config.logs_database)
end
svenfuchs
force-pushed
the
sf-instrumentation
branch
from
129c18b to
6db7be7
Compare
svenfuchs
force-pushed
the
sf-instrumentation
branch
from
13f3078 to
6c336e3
Compare
svenfuchs
force-pushed
the
sf-instrumentation
branch
from
068ca61 to
54ed777
Compare
svenfuchs
force-pushed
the
sf-instrumentation
branch
from
54ed777 to
1131ca6
Compare
svenfuchs
force-pushed
the
sf-instrumentation
branch
from
9599f33 to
afb3c2d
Compare
svenfuchs
force-pushed
the
sf-instrumentation
branch
from
afb3c2d to
a87fea0
Compare
svenfuchs
force-pushed
the
sf-instrumentation
branch
2 times, most recently
from
06740d5 to
60782e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes required for extracting travis-core from hub. Also includes https://github.com/travis-ci/travis-support/tree/sf-fix-log-newline (so far unmerged changes for github-sync)