always include sacnner.c to Swift package #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where the compilation process failed when tree-sitter-python was introduced using the Swift Package Manager.
That is, src/scanner.c exists but isn’t compiled in some Xcode/SwiftPM build contexts (e.g. when building an app/test target that depends on the package), leading to
Undefined symbol: _tree_sitter_python_external_scanner_create.Hardcoding sources:
["src/parser.c", "src/scanner.c"]fixes it.I believe this fix is reasonable since this repo actually has scanner.c.
The cause is the same as tree-sitter/tree-sitter-css#90.
It’s likely that other tree-sitter repositories sharing the same Package.swift template are experiencing the same issue, which should also be addressed.