fix(highlights): match constants with digits and leading underscores #327
+36
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constant highlight regex
^[A-Z][A-Z_]*$did not allow digits or leading underscores, so identifiers likeHTTP2,SHA256,_PRIVATEand__MAX_RETRIESwere not highlighted as constants despite following PEP 8 naming conventions.Updated the regex to
^_*[A-Z][A-Z_0-9]*$and added highlight tests for identifier naming conventions.