Skip to content

fix(webapp): return 415 for invalid SSO form content types #4238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericallam merged 1 commit into from
Jul 13, 2026
+14 −0
Merged

fix(webapp): return 415 for invalid SSO form content types #4238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .server-changes/sso-form-content-type.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
area: webapp
type: fix
---

Return a clear client error when SSO form submissions use an unsupported content type
8 changes: 8 additions & 0 deletions apps/webapp/app/routes/auth.sso.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,14 @@ export async function action({ request }: ActionFunctionArgs) {
return new Response(null, { status: 405 });
}

const contentType = request.headers.get("content-type")?.toLowerCase() ?? "";
if (
!contentType.includes("application/x-www-form-urlencoded") &&
!contentType.includes("multipart/form-data")
) {
Comment thread
carderne marked this conversation as resolved.
return new Response(null, { status: 415 });
}

const form = await request.formData();
const rawEmail = form.get("email");
if (typeof rawEmail !== "string" || rawEmail.trim().length === 0) {
Expand Down