Skip to content

chore(webapp,core): remove the unused ResourceMonitor server logging helper#4244

Merged
carderne merged 1 commit into
mainfrom
chore/remove-resource-monitor
Jul 13, 2026
Merged

chore(webapp,core): remove the unused ResourceMonitor server logging helper#4244
carderne merged 1 commit into
mainfrom
chore/remove-resource-monitor

Conversation

@carderne

Copy link
Copy Markdown
Collaborator

Summary

The ResourceMonitor server-side logging helper is no longer used. It periodically logged the webapp process own memory, disk, and CPU usage behind the RESOURCE_MONITOR_ENABLED flag (off by default), and was also exported from @trigger.dev/core/v3/serverOnly with no other consumers.

This removes the helper, its @trigger.dev/core export, the webapp wiring, and the RESOURCE_MONITOR_ENABLED env var. The supervisor has its own unrelated ResourceMonitor class, which is left untouched.

@changeset-bot

changeset-bot Bot commented Jul 13, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 7d8c4d8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 26 packages
Name Type
@trigger.dev/core Patch
@trigger.dev/build Patch
trigger.dev Patch
@trigger.dev/python Patch
@trigger.dev/redis-worker Patch
@trigger.dev/schema-to-json Patch
@trigger.dev/sdk Patch
@internal/cache Patch
@internal/clickhouse Patch
@internal/llm-model-catalog Patch
@trigger.dev/rbac Patch
@internal/redis Patch
@internal/replication Patch
@internal/run-engine Patch
@internal/run-store Patch
@internal/schedule-engine Patch
@trigger.dev/sso Patch
@internal/testcontainers Patch
@internal/tracing Patch
@internal/tsql Patch
@internal/dashboard-agent Patch
@internal/sdk-compat-tests Patch
@trigger.dev/react-hooks Patch
@trigger.dev/rsc Patch
@trigger.dev/database Patch
@trigger.dev/otlp-importer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

Removed the ResourceMonitor implementation and its @trigger.dev/core/v3/serverOnly re-export. Removed the webapp import, startup call, and RESOURCE_MONITOR_ENABLED environment setting. Added a changeset documenting the removal and marking @trigger.dev/core for a patch release.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description covers the change summary but omits the required issue link, checklist, testing, changelog, and screenshots sections. Add the template sections: Closes #, checklist items, testing steps, changelog, and screenshots, or mark any unused sections as N/A.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly states the main change and matches the webapp/core removals in the diff.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/remove-resource-monitor

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@carderne carderne marked this pull request as ready for review July 13, 2026 14:53

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Open in Devin Review

Comment thread packages/core/src/v3/serverOnly/index.ts
@carderne carderne enabled auto-merge (squash) July 13, 2026 15:06
@carderne carderne merged commit 64e5d73 into main Jul 13, 2026
61 checks passed
@carderne carderne deleted the chore/remove-resource-monitor branch July 13, 2026 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants