chore: standardise internal node on 24.18.0 by carderne · Pull Request #4254 · triggerdotdev/trigger.dev

carderne · 2026-07-14T10:49:04Z

Summary

Updates the internal development, CI, and runtime-image Node version to 24.18.0. SDK compatibility coverage continues to include Node 20, 22, 24, and 26.

The Node type definitions and the package-manager lockfiles now resolve against Node 24 types.

changeset-bot · 2026-07-14T10:49:08Z

⚠️ No Changeset found

Latest commit: d70b0f8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-07-14T10:49:35Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 2abdef31-b8d7-4885-a0a4-9932d17bf169

📥 Commits

Reviewing files that changed from the base of the PR and between a151594 and d70b0f8.

⛔ Files ignored due to path filters (4)

packages/cli-v3/e2e/fixtures/emit-decorator-metadata/package-lock.json is excluded by !**/package-lock.json
packages/cli-v3/e2e/fixtures/emit-decorator-metadata/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
packages/cli-v3/e2e/fixtures/emit-decorator-metadata/yarn.lock is excluded by !**/yarn.lock, !**/*.lock
pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (29)

.github/workflows/changesets-pr.yml
.github/workflows/claude.yml
.github/workflows/code-quality.yml
.github/workflows/dashboard-agent-deploy.yml
.github/workflows/e2e-webapp-auth-full.yml
.github/workflows/e2e-webapp.yml
.github/workflows/e2e.yml
.github/workflows/preview-packages.yml
.github/workflows/release.yml
.github/workflows/sdk-compat.yml
.github/workflows/typecheck.yml
.github/workflows/unit-tests-internal.yml
.github/workflows/unit-tests-packages.yml
.github/workflows/unit-tests-webapp.yml
.nvmrc
CONTRIBUTING.md
apps/supervisor/.nvmrc
apps/supervisor/Containerfile
docker/Dockerfile
internal-packages/otlp-importer/package.json
internal-packages/rbac/package.json
internal-packages/run-engine/src/run-queue/keyProducer.ts
internal-packages/run-store/src/PostgresRunStore.ts
internal-packages/sso/package.json
package.json
packages/cli-v3/e2e/fixtures/emit-decorator-metadata/package.json
packages/plugins/package.json
packages/python/package.json
packages/rsc/package.json

🚧 Files skipped from review as they are similar to previous changes (27)

packages/cli-v3/e2e/fixtures/emit-decorator-metadata/package.json
.github/workflows/e2e-webapp.yml
.github/workflows/dashboard-agent-deploy.yml
internal-packages/otlp-importer/package.json
docker/Dockerfile
.github/workflows/unit-tests-packages.yml
.nvmrc
.github/workflows/preview-packages.yml
.github/workflows/changesets-pr.yml
internal-packages/run-engine/src/run-queue/keyProducer.ts
.github/workflows/claude.yml
.github/workflows/code-quality.yml
.github/workflows/release.yml
packages/plugins/package.json
packages/python/package.json
.github/workflows/e2e.yml
apps/supervisor/Containerfile
.github/workflows/unit-tests-internal.yml
.github/workflows/unit-tests-webapp.yml
apps/supervisor/.nvmrc
package.json
internal-packages/sso/package.json
.github/workflows/typecheck.yml
internal-packages/rbac/package.json
internal-packages/run-store/src/PostgresRunStore.ts
.github/workflows/sdk-compat.yml
.github/workflows/e2e-webapp-auth-full.yml

📜 Recent review details

⏰ Context from checks skipped due to timeout. (34)

GitHub Check: webapp / 🧪 Unit Tests: Webapp (12, 12)
GitHub Check: webapp / 🧪 Unit Tests: Webapp (8, 12)
GitHub Check: webapp / 🧪 Unit Tests: Webapp (3, 12)
GitHub Check: webapp / 🧪 Unit Tests: Webapp (11, 12)
GitHub Check: webapp / 🧪 Unit Tests: Webapp (6, 12)
GitHub Check: webapp / 🧪 Unit Tests: Webapp (5, 12)
GitHub Check: webapp / 🧪 Unit Tests: Webapp (9, 12)
GitHub Check: webapp / 🧪 Unit Tests: Webapp (10, 12)
GitHub Check: webapp / 🧪 Unit Tests: Webapp (2, 12)
GitHub Check: webapp / 🧪 Unit Tests: Webapp (4, 12)
GitHub Check: webapp / 🧪 Unit Tests: Webapp (7, 12)
GitHub Check: webapp / 🧪 Unit Tests: Webapp (1, 12)
GitHub Check: sdk-compat / Node.js 22.23 (warp-ubuntu-latest-x64-4x)
GitHub Check: sdk-compat / Node.js 20.20 (warp-ubuntu-latest-x64-4x)
GitHub Check: packages / 🧪 Unit Tests: Packages (3, 3)
GitHub Check: sdk-compat / Node.js 26.4 (warp-ubuntu-latest-x64-4x)
GitHub Check: e2e / 🧪 CLI v3 tests (warp-windows-latest-x64-8x - npm)
GitHub Check: sdk-compat / Deno Runtime
GitHub Check: sdk-compat / Node.js 24.18 (warp-ubuntu-latest-x64-4x)
GitHub Check: e2e / 🧪 CLI v3 tests (warp-windows-latest-x64-8x - pnpm)
GitHub Check: packages / 🧪 Unit Tests: Packages (1, 3)
GitHub Check: packages / 🧪 Unit Tests: Packages (2, 3)
GitHub Check: e2e / 🧪 CLI v3 tests (warp-ubuntu-latest-x64-4x - npm)
GitHub Check: e2e / 🧪 CLI v3 tests (warp-ubuntu-latest-x64-4x - pnpm)
GitHub Check: sdk-compat / Cloudflare Workers
GitHub Check: sdk-compat / Bun Runtime
GitHub Check: typecheck / typecheck
GitHub Check: internal / 🧪 Unit Tests: Internal
GitHub Check: e2e-webapp / 🧪 E2E Tests: Webapp
GitHub Check: code-quality / code-quality
GitHub Check: 🛡️ E2E Auth Tests (full)
GitHub Check: audit
GitHub Check: Analyze (javascript-typescript)
GitHub Check: Build and publish previews

🧰 Additional context used

📓 Path-based instructions (1)

**/package.json

📄 CodeRabbit inference engine (AGENTS.md)

When adding Zod, use the exact repository-wide pinned version 3.25.76, never a different version or range.

Files:

packages/rsc/package.json

🔇 Additional comments (2)

CONTRIBUTING.md (1)

32-32: LGTM!

Also applies to: 52-52

packages/rsc/package.json (1)

48-48: LGTM!

Walkthrough

The pull request upgrades repository Node.js references from 22.23.1 to 24.18.0 across local version files, contributor documentation, GitHub Actions workflows, and container base images. Node.js type definitions are updated to 24.13.3 in package manifests. Two runtime code paths replace .at() array access with direct indexing while preserving their existing result handling.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description only includes a summary and omits the required issue link, checklist, testing, changelog, and screenshots sections.	Add the template sections: Closes `#issue`, checklist, testing steps, changelog summary, and screenshots or note N/A where appropriate.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title is concise and matches the main change: standardizing the internal Node.js version to 24.18.0.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch chore/tri-11592-node-24.18.0

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

pkg-pr-new · 2026-07-14T11:05:19Z

Open in StackBlitz

@trigger.dev/build

npm i https://pkg.pr.new/@trigger.dev/build@d70b0f8

trigger.dev

npm i https://pkg.pr.new/trigger.dev@d70b0f8

@trigger.dev/core

npm i https://pkg.pr.new/@trigger.dev/core@d70b0f8

@trigger.dev/python

npm i https://pkg.pr.new/@trigger.dev/python@d70b0f8

@trigger.dev/react-hooks

npm i https://pkg.pr.new/@trigger.dev/react-hooks@d70b0f8

@trigger.dev/redis-worker

npm i https://pkg.pr.new/@trigger.dev/redis-worker@d70b0f8

@trigger.dev/rsc

npm i https://pkg.pr.new/@trigger.dev/rsc@d70b0f8

@trigger.dev/schema-to-json

npm i https://pkg.pr.new/@trigger.dev/schema-to-json@d70b0f8

@trigger.dev/sdk

npm i https://pkg.pr.new/@trigger.dev/sdk@d70b0f8

commit: d70b0f8

devin-ai-integration

Devin Review found 2 potential issues.

devin-ai-integration · 2026-07-14T11:30:10Z

@@ -1,13 +1,13 @@
-FROM node:22-alpine@sha256:9bef0ef1e268f60627da9ba7d7605e8831d5b56ad07487d24d1aa386336d1944 AS node-22-alpine
+FROM node:24.18.0-alpine@sha256:a0b9bf06e4e6193cf7a0f58816cc935ff8c2a908f81e6f1a95432d679c54fbfd AS node-24-alpine


🔍 Docker image digests should be verified as multiplatform/index digests per repo rules

The AGENTS.md specifies: "Always use multiplatform/index digests, not architecture-specific digests" when updating Docker image references. The PR updates two digests:

apps/supervisor/Containerfile:1: sha256:a0b9bf06e4e6193cf7a0f58816cc935ff8c2a908f81e6f1a95432d679c54fbfd

docker/Dockerfile:1: sha256:39a4259b6f744868a8228742ad45aa3026f97302e5eec2fa4a38b30ca0a66e12

I cannot verify from the repository alone whether these are multiplatform index digests or architecture-specific ones. If they are arch-specific (e.g., pulled from an amd64 variant page), CI on ARM runners would fail. Worth a quick verification against Docker Hub.

Was this helpful? React with 👍 or 👎 to provide feedback.

carderne force-pushed the chore/tri-11592-node-24.18.0 branch from fbaf701 to a151594 Compare July 14, 2026 11:19

carderne marked this pull request as ready for review July 14, 2026 11:28

devin-ai-integration Bot reviewed Jul 14, 2026

View reviewed changes

carderne added 4 commits July 14, 2026 12:31

chore: standardise internal node on 24.18.0

62111f4

chore: regenerate fixture yarn lockfile

a65475b

fix(run-store): avoid Array.at in waitpoint count

5c7f1ce

fix(run-engine): avoid Array.at in queue key parser

d70b0f8

carderne force-pushed the chore/tri-11592-node-24.18.0 branch from a151594 to d70b0f8 Compare July 14, 2026 11:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

chore: standardise internal node on 24.18.0#4254

chore: standardise internal node on 24.18.0#4254
carderne wants to merge 4 commits into
mainfrom
chore/tri-11592-node-24.18.0

carderne commented Jul 14, 2026

Uh oh!

changeset-bot Bot commented Jul 14, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jul 14, 2026 •

edited

Loading

Reviews paused

❌ Failed checks (1 warning)

Uh oh!

pkg-pr-new Bot commented Jul 14, 2026 •

edited

Loading

Uh oh!

devin-ai-integration Bot left a comment

Uh oh!

devin-ai-integration Bot Jul 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

		@@ -1,13 +1,13 @@
		FROM node:22-alpine@sha256:9bef0ef1e268f60627da9ba7d7605e8831d5b56ad07487d24d1aa386336d1944 AS node-22-alpine
		FROM node:24.18.0-alpine@sha256:a0b9bf06e4e6193cf7a0f58816cc935ff8c2a908f81e6f1a95432d679c54fbfd AS node-24-alpine

Uh oh!

Uh oh!

Conversation

carderne commented Jul 14, 2026

Summary

Uh oh!

changeset-bot Bot commented Jul 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai Bot commented Jul 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

❌ Failed checks (1 warning)

Uh oh!

pkg-pr-new Bot commented Jul 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot Jul 14, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

changeset-bot Bot commented Jul 14, 2026 •

edited

Loading

coderabbitai Bot commented Jul 14, 2026 •

edited

Loading

pkg-pr-new Bot commented Jul 14, 2026 •

edited

Loading