Skip to content

NAS-140306 / 26.0.0-BETA.2 / Unable to save E-Mail options with GMail OAuth (by AlexKarpov98)#13358

Merged
william-gr merged 6 commits intostable/26from
NAS-140306-26.0.0-BETA.2
Mar 24, 2026
Merged

NAS-140306 / 26.0.0-BETA.2 / Unable to save E-Mail options with GMail OAuth (by AlexKarpov98)#13358
william-gr merged 6 commits intostable/26from
NAS-140306-26.0.0-BETA.2

Conversation

@bugclerk
Copy link
Copy Markdown
Contributor

Testing: see ticket & comment.

Actual changes:

  1. Email form fetches config from API when opened from the alerts panel (which passes no data), instead of showing an
    empty/broken form.
  2. Save button state fixed — properly enabled after switching from SMTP to Gmail OAuth and completing login, and when
    existing Gmail config is loaded.
  3. Port validator re-evaluated on send method change, so switching methods doesn't leave stale validation errors.
  4. Alert panel mat-menu z-index — custom OverlayContainer ensures dropdown menus render above the alert panel.
  5. Alert panel focus management — tab focus trapping added, focus returns to the alert bell on panel close.
  6. Menu items changed from to for semantic correctness (they trigger actions, not navigation to URLs).
  7. Removed unused SystemGeneralService dependency.

Preview:

Screen.Recording.2026-03-17.at.13.17.57.mov

Original PR: #13351

@bugclerk bugclerk requested a review from a team as a code owner March 19, 2026 12:17
@bugclerk bugclerk requested review from william-gr and removed request for a team March 19, 2026 12:17
@bugclerk
Copy link
Copy Markdown
Contributor Author

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 19, 2026

Codecov Report

❌ Patch coverage is 52.08333% with 23 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (stable/26@16a8c65). Learn more about missing BASE report.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ules/layout/admin-layout/admin-layout.component.ts 0.00% 20 Missing ⚠️
...rts-panel/alert-panel-overlay-container.service.ts 50.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             stable/26   #13358   +/-   ##
============================================
  Coverage             ?   86.61%           
============================================
  Files                ?     1872           
  Lines                ?    72027           
  Branches             ?     8400           
============================================
  Hits                 ?    62389           
  Misses               ?     9638           
  Partials             ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ported.

@william-gr william-gr merged commit 909002f into stable/26 Mar 24, 2026
12 of 13 checks passed
@william-gr william-gr deleted the NAS-140306-26.0.0-BETA.2 branch March 24, 2026 11:55
@bugclerk
Copy link
Copy Markdown
Contributor Author

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Mar 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants