Add --no-ctap1 and --non-interactive test flags#61
Open
Conversation
Annotate tests requiring user presence or device reboot with @pytest.mark.interactive. Add --non-interactive CLI flag to skip them. Mark test_bad_type_rp_icon as xfail (known firmware issue). Result: 140 passed, 61 skipped, 1 xfailed, 0 failures. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The solokeys vendor path in conftest.py handles device reboots automatically via vendor CTAP command 0x53, so no interactive markers are needed. Run tests with: pytest --vendor solokeys Result: 175 passed, 5 failed, 12 skipped, 1 xfailed, 9 errors (3m04s) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Mark U2F and CTAP1 interop tests with @pytest.mark.ctap1 - Add --no-ctap1 CLI flag to skip them - Mark UP tests that require real button (test_no_user_presence, test_user_presence_permits_only_one_request, test_keep_alive) with @pytest.mark.interactive Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--no-ctap1flag to skip CTAP1/U2F tests (marked with@pytest.mark.ctap1)--non-interactiveflag to skip tests requiring real user presence (marked with@pytest.mark.interactive)test_bad_type_rp_iconas xfail (known firmware issue)--vendor solokeysfor automatic device reboot via vendor CTAP commandTest results on Solo2 (LPC55S69, no-buttons firmware)
Remaining 2 failures are firmware bugs in credential management pin auth validation.
Test plan
pytest tests/standard --vendor solokeys --no-ctap1 --non-interactive --timeout 30--no-ctap1--non-interactive🤖 Generated with Claude Code