docs: Add reference values flow#44
Merged
Merged
Conversation
alicefr
reviewed
Oct 6, 2025
alicefr
reviewed
Oct 6, 2025
alicefr
reviewed
Oct 6, 2025
| { | ||
| "version": "0.1.0", | ||
| "name": "tpm_pcr4", | ||
| "expiration": "2026-10-02T13:00:13Z", |
Contributor
There was a problem hiding this comment.
Is the expiration on the entire list or on each single value?
Contributor
Author
There was a problem hiding this comment.
It's on the Trustee RVPS resource of the particular name tpm_pcr4. As of now, each time the reference values update, we accumulate all and set them to expire in 365 days. This could be refined and then it may (read: did not test) be possible to have multiple reference values with the same name (after all, it's not a dictionary key) but different expiration times.
Contributor
There was a problem hiding this comment.
it would make more sense to me that having a generic expiration time, but it is for sure a more advanced topic
This was referenced Oct 16, 2025
527ff14 to
99e94dd
Compare
Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
99e94dd to
cab48f7
Compare
bgartzi
approved these changes
Oct 28, 2025
Contributor
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design proposal (partially implemented but open to comments on anything)