Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ dependencies = [
[project.optional-dependencies]
dev = [
"build==1.5.0",
"isort==8.0.1",
"mypy==2.1.0",
"pip-audit==2.10.0",
"pre-commit==4.6.0",
Expand All @@ -45,12 +44,6 @@ src = ["src", "tests", "scripts"]
[tool.ruff.lint]
select = ["E", "F", "I", "UP", "B"]

[tool.isort]
profile = "black"
line_length = 88
src_paths = ["src", "tests"]
known_first_party = ["probaboracle"]

[tool.mypy]
python_version = "3.10"
mypy_path = "src"
Expand Down
1 change: 0 additions & 1 deletion src/probaboracle/doctor_env.py
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,6 @@ def _check_imports() -> int:

optional_dev_modules = [
"build",
"isort",
"mypy",
]
for name in optional_dev_modules:
Expand Down
12 changes: 12 additions & 0 deletions tests/test_tooling_contract.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,18 @@ def test_runtime_docs_name_the_make_targets(self) -> None:
):
self.assertIn(command, docs)

def test_import_sorting_is_owned_by_ruff_not_isort_extension(self) -> None:
pyproject = read("pyproject.toml")
doctor = read("src/probaboracle/doctor_env.py")

self.assertIn('select = ["E", "F", "I", "UP", "B"]', pyproject)
self.assertIn("ruff check scripts src tests", read("Makefile"))
self.assertIn("ruff format --check scripts src tests", read("Makefile"))

self.assertNotIn('"isort', pyproject)
self.assertNotIn("[tool.isort]", pyproject)
self.assertNotIn('"isort"', doctor)


if __name__ == "__main__":
unittest.main()