Cache load3DModel results#892
Open
Jam-Ngai wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
load3DModelso duplicate model URLs share the same in-flight or completed load.cachebust_originout of cache keys while preserving the original URL passed to Three loaders..obj,.stl,.wrl,.gltf, and.glbURLs still select the correct loader.Verification
git diff --checkI could not run the Bun/TypeScript test suite locally because this environment does not have
bun,npm,tsc, orbiomeinstalled, and the Homebrew GitHub download path was timing out earlier.AI-assisted with Codex and manually reviewed.
/claim #93