Skip to content

test: add pcb snapshot for polygon smtpads with coveredWithSolderMask#1985

Open
ETwithin wants to merge 2 commits intotscircuit:mainfrom
ETwithin:feat/smtpad-polygon-covered-with-solder-mask
Open

test: add pcb snapshot for polygon smtpads with coveredWithSolderMask#1985
ETwithin wants to merge 2 commits intotscircuit:mainfrom
ETwithin:feat/smtpad-polygon-covered-with-solder-mask

Conversation

@ETwithin
Copy link

@ETwithin ETwithin commented Mar 1, 2026

Summary

Adds a PCB snapshot test demonstrating that polygon-shaped smtpads correctly:

  1. Propagate is_covered_with_solder_mask: true in circuit-json output
  2. Render with the solder mask layer visible via showSolderMask: true

Test Details

The test uses a 5-pad capacitive touch slider layout (short → tall → short) matching the design from tscircuit/tscircuit#786:

const pads = [
  { name: "PAD1", pcbX: -8, width: 2.5, height: 6 },
  { name: "PAD2", pcbX: -4, width: 2.5, height: 8 },
  { name: "PAD3", pcbX:  0, width: 2.5, height: 10 },
  { name: "PAD4", pcbX:  4, width: 2.5, height: 8 },
  { name: "PAD5", pcbX:  8, width: 2.5, height: 6 },
]

Each pad uses shape="polygon" with coveredWithSolderMask={true}.

Assertions

  • All 5 pcb_smtpad elements have is_covered_with_solder_mask: true
  • All pads retain shape: "polygon" and points array in circuit-json
  • PCB snapshot renders with solder mask layer visible

Related

Closes tscircuit/tscircuit#786 (partial)

Adds a PCB snapshot test demonstrating that polygon-shaped smtpads
correctly propagate is_covered_with_solder_mask: true in circuit-json
output and render with the solder mask layer visible.

The test uses a 5-pad capacitive touch slider layout (short→tall→short)
matching the design from the issue.
@vercel
Copy link

vercel bot commented Mar 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
tscircuit-core-benchmarks Ready Ready Preview, Comment Mar 1, 2026 8:21am

Request Review

@github-actions
Copy link

github-actions bot commented Mar 4, 2026

This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant