refactor: update type annotations for better type safety in normal components#1989
Open
nailoo wants to merge 1 commit intotscircuit:mainfrom
Open
refactor: update type annotations for better type safety in normal components#1989nailoo wants to merge 1 commit intotscircuit:mainfrom
nailoo wants to merge 1 commit intotscircuit:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
@MustafaMulla29 can you review it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves type safety across several "normal components" by replacing generic
as anytype assertions with specific types fromcircuit-json. It also removes unnecessary@ts-ignorecomments that were previously silencing type errors.Changes
as anywith explicitcircuit-jsontypes in the following components:Diode(usingSourceSimpleDiode)Mosfet(usingSourceSimpleMosfet)PowerSource(usingSourceSimplePowerSource)Transistor(usingSourceSimpleTransistor)VoltageSource(usingSourceSimpleVoltageSource)// @ts-ignorecomments where type safety is now correctly handled.circuit-jsondefinitions.