Add support for platform DRC-disable flags#2003
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
netlistDrcChecksDisabled,placementDrcChecksDisabled, androutingDrcChecksDisabledand incorporate them into DRC gating logic inlib/components/normal-components/Board.tssoshouldRunNetlistChecks,shouldRunPlacementChecks, andshouldRunRoutingChecksare computed from both existingpcbDisabled/routingDisabledand the new flags.@tscircuit/propsto^0.0.487to obtain the updatedPlatformConfigtypings that include these flags and updatedpackage.jsonaccordingly.tests/root-circuit/platform-drc-checks-disabled.test.tsxto verifynetlistDrcChecksDisabledandplacementDrcChecksDisabledsuppress the corresponding DRC errors.Testing
bun test tests/root-circuit/platform-drc-checks-disabled.test.tsxand both tests passed.bun test tests/root-circuit/platform-routing-disabled.test.tsxand it passed.bunx tsc --noEmitfor full type-checking and it passed with no errors.bun run formatto format code changes.Codex Task