Fix global objectLimit rendering cap#214
Open
8npyvz5bd8-lang wants to merge 3 commits into
Open
Conversation
Apply objectLimit after filtering across all rendered object groups and keep the warning count based on the pre-limit filtered total.
Add a typed helper that applies one global object cap and reports the pre-limit filtered count.
Cover global capping, no-limit truncation, and zero-limit behavior for InteractiveGraphics objectLimit.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #42
Summary:
objectLimitonce across all rendered InteractiveGraphics object groups after layer/step/viewport filters run.Verification:
bun x biome format --write site/components/InteractiveGraphics/InteractiveGraphics.tsx site/components/InteractiveGraphics/applyObjectLimit.ts tests/applyObjectLimit.test.ts-> passedbun -e "import { applyObjectLimit } from './site/components/InteractiveGraphics/applyObjectLimit.ts'; ..."-> applyObjectLimit smoke passedbun run build-> passedbun test tests/applyObjectLimit.test.ts-> blocked locally because the repo-level bunfig preload importsbun-match-svg, which loadssharp;bun install --frozen-lockfilefailed on this Windows machine because node-gyp could not find Visual Studio C++ build tools. The focused helper was verified with the smoke check above.Disclosure: AI-assisted with Codex; I reviewed the patch and kept it scoped to the object limit behavior.