make direction optional in portProps schema#600
make direction optional in portProps schema#600shehaban wants to merge 12 commits intotscircuit:mainfrom
Conversation
|
@seveibar I’m working on the core to use portProps from the props instead of defining it inside the core. It was previously defined as optional in corePortProps. |
|
Why does it need to be optional? Why not make required |
|
Because making it required will break existing tests, around 300 snapshot tests will fail |
Nothing will break it's a required property. |
|
@seveibar @MustafaMulla29 It was optional in core, and I moved it as it was.
|
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |

🎯 Why this change is needed
directionfield is already optional in the coreportProps.portPropsfrom@tscircuit/propsinstead of declaring it inside core.