laser_scanner: fix off-by-one in angle_increment calculation#59
Open
gavanderhoorn wants to merge 1 commit intotud-cor:masterfrom
Open
laser_scanner: fix off-by-one in angle_increment calculation#59gavanderhoorn wants to merge 1 commit intotud-cor:masterfrom
angle_increment calculation#59gavanderhoorn wants to merge 1 commit intotud-cor:masterfrom
Conversation
Technically this could just be 'LS_FOV' now, but let's refactor some other time.
|
@gavanderhoorn I may be doing something wrong, but don't really see any difference on my setup, the scan is still either whole 360° around the vehicle or rotated if I change the max and min angles. How have you configured the scan in mod_config.lua? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This may fix the issues experienced by @ashchennikov in #57.
Some quick tests (
fov: 5 degreesandfov: 90 degrees) show this to work:(scans of the little pickets in front of the isles of the gas station with FOV: 90 degrees (
[-45; 45]). Note: perspective is not identical, the laser scanner is mounted in front of the vehicle)If you're still interested @ashchennikov, please give this a test.
I'll merge this next week, unless I find something is still wrong and/or someone reports an(other) issue with it.