Skip to content

[Viewer] Bugfix for missing TransformerContext#66

Closed
jokap11 wants to merge 1 commit intotum-ei-eda:coredsl2from
jokap11:coredsl2
Closed

[Viewer] Bugfix for missing TransformerContext#66
jokap11 wants to merge 1 commit intotum-ei-eda:coredsl2from
jokap11:coredsl2

Conversation

@jokap11
Copy link

@jokap11 jokap11 commented Mar 16, 2026

No description provided.

@PhilippvK
Copy link
Member

The correct bug fix would be to use "TreeGenContext". This bug is a copy-paste issue when I tried to fix all places which where missing def procedure_call(self: behav.ProcedureCall, context: TransformerContext):.

behav.ProcedureCall vs. behav.Callable is actually the problem I have mentione don Friday. Only defining one of them can lead to flaky behavior because un-overriden methods will be whatever was defined in the previous transform...

@PhilippvK
Copy link
Member

@jokap11 Maybe you could look into

def patch_model(module):
to find a way which resets all generate functions to a default (no-op) visitor, to avoid this kind of issue.

@jokap11
Copy link
Author

jokap11 commented Mar 20, 2026

Yeah you are right regarding the TreeGenContext.
I tried to fix the patch_model "monkey_patching" with another branch #67

@jokap11 jokap11 closed this Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants