Drop 'Description' property from role assignment entity

src/Turnierplan.App/Client/src/app/portal/components/rbac-add-assignment/rbac-add-assignment.component.ts

@@ -69,7 +69,6 @@ export class RbacAddAssignmentComponent implements OnDestroy {
     const request: CreateRoleAssignmentEndpointRequest = {
       scopeId: this.targetScopeId,
       role: this.selectedRole,
-      description: null, // TODO
       apiKeyId: this.selectedPrincipalKind === PrincipalKind.ApiKey ? this.searchPrincipalInput.trim() : null,
       userEmail: this.selectedPrincipalKind === PrincipalKind.User ? this.searchPrincipalInput.trim() : null
     };

src/Turnierplan.App/Endpoints/RoleAssignments/CreateRoleAssignmentEndpoint.cs

@@ -16,7 +16,6 @@
 using Turnierplan.Core.Tournament;
 using Turnierplan.Core.User;
 using Turnierplan.Core.Venue;
-using Turnierplan.Dal;
 
 namespace Turnierplan.App.Endpoints.RoleAssignments;
 
@@ -104,7 +103,7 @@ private static async Task<IResult> CreateRoleAssignmentAsync<T>(
             return Results.Conflict("There already exists a role assignment for the specified principal/role combination.");
         }
 
-        var roleAssignment = entity.AddRoleAssignment(request.Role, principal, request.Description);
+        var roleAssignment = entity.AddRoleAssignment(request.Role, principal);
 
         await roleAssignmentRepository.CreateAsync(roleAssignment).ConfigureAwait(false);
         await repository.UnitOfWork.SaveChangesAsync(cancellationToken).ConfigureAwait(false);
@@ -143,8 +142,6 @@ public sealed record CreateRoleAssignmentEndpointRequest
         public required PublicId? ApiKeyId { get; init; }
 
         public required string? UserEmail { get; init; }
-
-        public required string? Description { get; init; }
     }
 
     private sealed class Validator : AbstractValidator<CreateRoleAssignmentEndpointRequest>
@@ -162,11 +159,6 @@ private Validator()
             RuleFor(x => x)
                 .Must(x => x.ApiKeyId is null ^ x.UserEmail is null)
                 .WithMessage($"Exactly only one of {nameof(CreateRoleAssignmentEndpointRequest.ApiKeyId)} and {nameof(CreateRoleAssignmentEndpointRequest.UserEmail)} must be specified.");
-
-            RuleFor(x => x.Description)
-                .NotEmpty()
-                .MaximumLength(ValidationConstants.RoleAssignment.MaxDescriptionLength)
-                .When(x => x.Description is not null);
         }
     }
 }

src/Turnierplan.App/Mapping/Rules/RoleAssignmentMappingRule.cs

@@ -28,7 +28,6 @@ protected override RoleAssignmentDto Map(IMapper mapper, MappingContext context,
                 Kind = source.Principal.Kind,
                 PrincipalId = source.Principal.PrincipalId
             },
-            Description = source.Description,
             IsInherited = false
         };
     }

src/Turnierplan.App/Models/RoleAssignmentDto.cs

@@ -16,7 +16,5 @@ public sealed record RoleAssignmentDto
 
     public required PrincipalDto Principal { get; init; }
 
-    public required string Description { get; init; }
-
     public required bool IsInherited { get; init; }
 }

src/Turnierplan.Core/ApiKey/ApiKey.cs

@@ -24,7 +24,7 @@
         IsActive = true;
     }
 
     internal ApiKey(long id, Guid principalId, PublicId.PublicId publicId, string name, string description, string secretHash, DateTime createdAt, DateTime expiryDate, bool isActive)
     {
         Id = id;
         PrincipalId = principalId;
@@ -63,9 +63,9 @@
 
     public IReadOnlyList<ApiKeyRequest> Requests => _requests.AsReadOnly();
 
-    public RoleAssignment<ApiKey> AddRoleAssignment(Role role, Principal principal, string? description = null)
+    public RoleAssignment<ApiKey> AddRoleAssignment(Role role, Principal principal)
     {
-        var roleAssignment = new RoleAssignment<ApiKey>(this, role, principal, description);
+        var roleAssignment = new RoleAssignment<ApiKey>(this, role, principal);
         _roleAssignments.Add(roleAssignment);
 
         return roleAssignment;

src/Turnierplan.Core/Folder/Folder.cs

@@ -41,9 +41,9 @@ internal Folder(long id, PublicId.PublicId publicId, DateTime createdAt, string
 
     public IReadOnlyList<Tournament.Tournament> Tournaments => _tournaments.AsReadOnly();
 
-    public RoleAssignment<Folder> AddRoleAssignment(Role role, Principal principal, string? description = null)
+    public RoleAssignment<Folder> AddRoleAssignment(Role role, Principal principal)
     {
-        var roleAssignment = new RoleAssignment<Folder>(this, role, principal, description);
+        var roleAssignment = new RoleAssignment<Folder>(this, role, principal);
         _roleAssignments.Add(roleAssignment);
 
         return roleAssignment;

src/Turnierplan.Core/Image/Image.cs

@@ -27,7 +27,7 @@
         Height = height;
     }
 
     internal Image(long id, Guid resourceIdentifier, PublicId.PublicId publicId, DateTime createdAt, string name, ImageType type, string fileType, long fileSize, ushort width, ushort height)
     {
         Id = id;
         ResourceIdentifier = resourceIdentifier;
@@ -65,9 +65,9 @@
 
     public ushort Height { get; }
 
-    public RoleAssignment<Image> AddRoleAssignment(Role role, Principal principal, string? description = null)
+    public RoleAssignment<Image> AddRoleAssignment(Role role, Principal principal)
     {
-        var roleAssignment = new RoleAssignment<Image>(this, role, principal, description);
+        var roleAssignment = new RoleAssignment<Image>(this, role, principal);
         _roleAssignments.Add(roleAssignment);
 
         return roleAssignment;

src/Turnierplan.Core/Organization/Organization.cs

@@ -48,9 +48,9 @@ internal Organization(long id, PublicId.PublicId publicId, DateTime createdAt, s
 
     public IReadOnlyList<Venue.Venue> Venues => _venues.AsReadOnly();
 
-    public RoleAssignment<Organization> AddRoleAssignment(Role role, Principal principal, string? description = null)
+    public RoleAssignment<Organization> AddRoleAssignment(Role role, Principal principal)
     {
-        var roleAssignment = new RoleAssignment<Organization>(this, role, principal, description);
+        var roleAssignment = new RoleAssignment<Organization>(this, role, principal);
         _roleAssignments.Add(roleAssignment);
 
         return roleAssignment;

src/Turnierplan.Core/RoleAssignment/RoleAssignment.cs

@@ -5,23 +5,21 @@ namespace Turnierplan.Core.RoleAssignment;
 public sealed class RoleAssignment<T> : Entity<Guid>
     where T : Entity<long>, IEntityWithRoleAssignments<T>
 {
-    internal RoleAssignment(T scope, Role role, Principal principal, string? description = null)
+    internal RoleAssignment(T scope, Role role, Principal principal)
     {
         Id = Guid.NewGuid();
         Scope = scope;
         CreatedAt =  DateTime.UtcNow;
         Role = role;
         Principal = principal;
-        Description = description ?? string.Empty;
     }
 
-    internal RoleAssignment(Guid id, DateTime createdAt, Role role, Principal principal, string description)
+    internal RoleAssignment(Guid id, DateTime createdAt, Role role, Principal principal)
     {
         Id = id;
         CreatedAt = createdAt;
         Role = role;
         Principal = principal;
-        Description = description;
     }
 
     public override Guid Id { get; protected set; }
@@ -33,6 +31,4 @@ internal RoleAssignment(Guid id, DateTime createdAt, Role role, Principal princi
     public Role Role { get; }
 
     public Principal Principal { get; }
-
-    public string Description { get; set; }
 }

src/Turnierplan.Core/SeedWork/IEntityWithRoleAssignments.cs

@@ -9,7 +9,7 @@ public interface IEntityWithRoleAssignments<T> : IEntityWithPublicId
 
     IReadOnlyList<RoleAssignment<T>> RoleAssignments { get; }
 
-    RoleAssignment<T> AddRoleAssignment(Role role, Principal principal, string? description = null);
+    RoleAssignment<T> AddRoleAssignment(Role role, Principal principal);
 
     void RemoveRoleAssignment(RoleAssignment<T> roleAssignment);
 }

src/Turnierplan.Core/Tournament/Tournament.cs

@@ -147,9 +147,9 @@
         }
     }
 
-    public RoleAssignment<Tournament> AddRoleAssignment(Role role, Principal principal, string? description = null)
+    public RoleAssignment<Tournament> AddRoleAssignment(Role role, Principal principal)
     {
-        var roleAssignment = new RoleAssignment<Tournament>(this, role, principal, description);
+        var roleAssignment = new RoleAssignment<Tournament>(this, role, principal);
         _roleAssignments.Add(roleAssignment);
 
         return roleAssignment;
@@ -267,7 +267,7 @@
 
     public void ShiftToTimezone(TimeZoneInfo timeZone)
     {
         foreach (var match in _matches)
         {
             if (match.Kickoff is not null)
             {
@@ -433,7 +433,7 @@
         }
     }
 
     public List<RefereeCard> GenerateRefereeCards()
     {
         var cards = new List<RefereeCard>();
         var groupRefereeMap = new Dictionary<Group, Group>();
@@ -529,7 +529,7 @@
         }
     }
 
     private void ComputeGroupPhaseResults()
     {
         foreach (var group in _groups)
         {
@@ -560,7 +560,7 @@
         }
     }
 
     private void ComputeRanking()
     {
         var matchesWithRankingInfluence = new HashSet<Match>();
         var undefinedRankings = Enumerable.Range(1, _teams.Count).ToList();
@@ -751,7 +751,7 @@
         }
     }
 
     private void GenerateFinalsMatches(FinalsRoundConfig? config, int matchIndexOffset)
     {
         if (config is null)
         {
@@ -894,7 +894,7 @@
         }
     }
 
     private void GenerateSchedule(ScheduleConfig? config)
     {
         if (config is null)
         {

src/Turnierplan.Core/Venue/Venue.cs

@@ -49,9 +49,9 @@ internal Venue(long id, PublicId.PublicId publicId, DateTime createdAt, string n
 
     public IReadOnlyList<Tournament.Tournament> Tournaments => _tournaments.AsReadOnly();
 
-    public RoleAssignment<Venue> AddRoleAssignment(Role role, Principal principal, string? description = null)
+    public RoleAssignment<Venue> AddRoleAssignment(Role role, Principal principal)
     {
-        var roleAssignment = new RoleAssignment<Venue>(this, role, principal, description);
+        var roleAssignment = new RoleAssignment<Venue>(this, role, principal);
         _roleAssignments.Add(roleAssignment);
 
         return roleAssignment;

src/Turnierplan.Dal/EntityConfigurations/RoleAssignmentEntityTypeConfiguration.cs

@@ -27,9 +27,5 @@ public void Configure(EntityTypeBuilder<RoleAssignment<T>> builder)
         builder.Property(x => x.Principal)
             .IsRequired()
             .HasConversion<PrincipalConverter>();
-
-        builder.Property(x => x.Description)
-            .IsRequired()
-            .HasMaxLength(ValidationConstants.RoleAssignment.MaxDescriptionLength);
     }
 }

src/Turnierplan.Dal/Migrations/20250621085230_Add_RBAC.cs → src/Turnierplan.Dal/Migrations/20250627142711_Add_Rbac.cs

@@ -6,7 +6,7 @@
 namespace Turnierplan.Dal.Migrations
 {
     /// <inheritdoc />
-    public partial class Add_RBAC : Migration
+    public partial class Add_Rbac : Migration
     {
         /// <inheritdoc />
         protected override void Up(MigrationBuilder migrationBuilder)
@@ -65,8 +65,7 @@ protected override void Up(MigrationBuilder migrationBuilder)
                     ApiKeyId = table.Column<long>(type: "bigint", nullable: false),
                     CreatedAt = table.Column<DateTime>(type: "timestamp with time zone", nullable: false),
                     Role = table.Column<int>(type: "integer", nullable: false),
-                    Principal = table.Column<string>(type: "text", nullable: false),
-                    Description = table.Column<string>(type: "character varying(250)", maxLength: 250, nullable: false)
+                    Principal = table.Column<string>(type: "text", nullable: false)
                 },
                 constraints: table =>
                 {
@@ -89,8 +88,7 @@ protected override void Up(MigrationBuilder migrationBuilder)
                     FolderId = table.Column<long>(type: "bigint", nullable: false),
                     CreatedAt = table.Column<DateTime>(type: "timestamp with time zone", nullable: false),
                     Role = table.Column<int>(type: "integer", nullable: false),
-                    Principal = table.Column<string>(type: "text", nullable: false),
-                    Description = table.Column<string>(type: "character varying(250)", maxLength: 250, nullable: false)
+                    Principal = table.Column<string>(type: "text", nullable: false)
                 },
                 constraints: table =>
                 {
@@ -113,8 +111,7 @@ protected override void Up(MigrationBuilder migrationBuilder)
                     ImageId = table.Column<long>(type: "bigint", nullable: false),
                     CreatedAt = table.Column<DateTime>(type: "timestamp with time zone", nullable: false),
                     Role = table.Column<int>(type: "integer", nullable: false),
-                    Principal = table.Column<string>(type: "text", nullable: false),
-                    Description = table.Column<string>(type: "character varying(250)", maxLength: 250, nullable: false)
+                    Principal = table.Column<string>(type: "text", nullable: false)
                 },
                 constraints: table =>
                 {
@@ -137,8 +134,7 @@ protected override void Up(MigrationBuilder migrationBuilder)
                     OrganizationId = table.Column<long>(type: "bigint", nullable: false),
                     CreatedAt = table.Column<DateTime>(type: "timestamp with time zone", nullable: false),
                     Role = table.Column<int>(type: "integer", nullable: false),
-                    Principal = table.Column<string>(type: "text", nullable: false),
-                    Description = table.Column<string>(type: "character varying(250)", maxLength: 250, nullable: false)
+                    Principal = table.Column<string>(type: "text", nullable: false)
                 },
                 constraints: table =>
                 {
@@ -161,8 +157,7 @@ protected override void Up(MigrationBuilder migrationBuilder)
                     TournamentId = table.Column<long>(type: "bigint", nullable: false),
                     CreatedAt = table.Column<DateTime>(type: "timestamp with time zone", nullable: false),
                     Role = table.Column<int>(type: "integer", nullable: false),
-                    Principal = table.Column<string>(type: "text", nullable: false),
-                    Description = table.Column<string>(type: "character varying(250)", maxLength: 250, nullable: false)
+                    Principal = table.Column<string>(type: "text", nullable: false)
                 },
                 constraints: table =>
                 {
@@ -185,8 +180,7 @@ protected override void Up(MigrationBuilder migrationBuilder)
                     VenueId = table.Column<long>(type: "bigint", nullable: false),
                     CreatedAt = table.Column<DateTime>(type: "timestamp with time zone", nullable: false),
                     Role = table.Column<int>(type: "integer", nullable: false),
-                    Principal = table.Column<string>(type: "text", nullable: false),
-                    Description = table.Column<string>(type: "character varying(250)", maxLength: 250, nullable: false)
+                    Principal = table.Column<string>(type: "text", nullable: false)
                 },
                 constraints: table =>
                 {
@@ -261,8 +255,8 @@ protected override void Up(MigrationBuilder migrationBuilder)
             // 1000 is the numerical value for the "Owner" role
 
             migrationBuilder.Sql("""
-INSERT INTO turnierplan."IAM_Organization" ("Id", "OrganizationId", "CreatedAt", "Role", "Principal", "Description")
-SELECT gen_random_uuid(), "Organizations"."Id", NOW(), 1000, ('User:' || "Users"."PrincipalId"), ''
+INSERT INTO turnierplan."IAM_Organization" ("Id", "OrganizationId", "CreatedAt", "Role", "Principal")
+SELECT gen_random_uuid(), "Organizations"."Id", NOW(), 1000, ('User:' || "Users"."PrincipalId")
 FROM turnierplan."Organizations"
 INNER JOIN turnierplan."Users" ON "Organizations"."OwnerId" = "Users"."Id";
 """);