Skip to content

Remove restriction that match outcome 'AfterPenalties' requires non-draw #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eliaspr merged 2 commits into from
Jun 29, 2025
Merged

Remove restriction that match outcome 'AfterPenalties' requires non-draw #60

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eccfb39
rm
eliaspr Jun 29, 2025
40af586
simplify if
eliaspr Jun 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions src/Turnierplan.Core/Tournament/Match.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,17 +82,9 @@ internal Match(int id, int index, TeamSelectorBase teamSelectorA, TeamSelectorBa

public void SetOutcome(bool isCurrentlyPlaying, int scoreA, int scoreB, MatchOutcomeType outcomeType)
{
if (!isCurrentlyPlaying)
if (!isCurrentlyPlaying && IsDecidingMatch && scoreA == scoreB)
{
if (IsDecidingMatch && scoreA == scoreB)
{
throw new TurnierplanException("Deciding matches cannot end with a draw.");
}

if (outcomeType == MatchOutcomeType.AfterPenalties && scoreA == scoreB)
{
throw new TurnierplanException($"When outcome type is '{nameof(MatchOutcomeType.AfterPenalties)}', the match may not be a draw.");
}
throw new TurnierplanException("Deciding matches cannot end with a draw.");
}

IsCurrentlyPlaying = isCurrentlyPlaying;
Expand Down
Loading