Skip to content

Require 'Owner' role for deleting an organization #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eliaspr merged 5 commits into from
Jul 6, 2025
Merged

Require 'Owner' role for deleting an organization #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
56a8ba5
Add GenericDelete action
eliaspr Jul 1, 2025
9efebdf
Fix wrong permission check for api keys
eliaspr Jul 1, 2025
5f35315
Add Owner role assignments when creating stuff
eliaspr Jul 4, 2025
66952a9
Revert "Add Owner role assignments when creating stuff"
eliaspr Jul 6, 2025
f188e55
Switch to using 'PrivilegedDelete' action
eliaspr Jul 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Turnierplan.App/Endpoints/ApiKeys/DeleteApiKeyEndpoint.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ private static async Task<IResult> Handle(
return Results.NotFound();
}

if (!accessValidator.IsActionAllowed(apiKey.Organization, Actions.GenericWrite))
if (!accessValidator.IsActionAllowed(apiKey, Actions.GenericWrite))
{
return Results.Forbid();
}
Expand Down
2 changes: 1 addition & 1 deletion src/Turnierplan.App/Endpoints/ApiKeys/GetApiKeyUsageEndpoint.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ private static async Task<IResult> Handle(
return Results.NotFound();
}

if (!accessValidator.IsActionAllowed(apiKey.Organization, Actions.GenericRead))
if (!accessValidator.IsActionAllowed(apiKey, Actions.GenericRead))
{
return Results.Forbid();
}
Expand Down
2 changes: 1 addition & 1 deletion src/Turnierplan.App/Endpoints/ApiKeys/SetApiKeyStatusEndpoint.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ private static async Task<IResult> Handle(
return Results.NotFound();
}

if (!accessValidator.IsActionAllowed(apiKey.Organization, Actions.GenericWrite))
if (!accessValidator.IsActionAllowed(apiKey, Actions.GenericWrite))
{
return Results.Forbid();
}
Expand Down
2 changes: 1 addition & 1 deletion src/Turnierplan.App/Endpoints/Organizations/DeleteOrganizationEndpoint.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ private static async Task<IResult> Handle(
return Results.NotFound();
}

if (!accessValidator.IsActionAllowed(organization, Actions.GenericWrite))
if (!accessValidator.IsActionAllowed(organization, Actions.PrivilegedDelete))
{
return Results.Forbid();
}
Expand Down
5 changes: 5 additions & 0 deletions src/Turnierplan.App/Security/Actions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@ internal static class Actions
/// </summary>
public static readonly Action ReadOrWriteRoleAssignments = new(Role.Owner);

/// <summary>
/// A special kind of delete action which shall require the <see cref="Role.Owner"/> role on the target entity.
/// </summary>
public static readonly Action PrivilegedDelete = new(Role.Owner);

/// <summary>
/// Any action that modifies some entity.
/// </summary>
Expand Down
Loading