Updated to support image captions#17
Open
ETfrom2100 wants to merge 17 commits intotutorialzine:masterfrom
Open
Updated to support image captions#17ETfrom2100 wants to merge 17 commits intotutorialzine:masterfrom
ETfrom2100 wants to merge 17 commits intotutorialzine:masterfrom
Conversation
need to fix some bugs
fix some comments
animation for #caption-container
also trigger on the caption container;
|
Thanks for adding support image captions, and thanks to noXon68 for the bugfix. There still is one problem, regarding the use of more than one gallery (data-gallery) in same page, with different names (eg. data-gallery="3" and data-gallery="4"). It seems that the captions get mixed up, from the two different galleries. |
|
Thanks again, for fixing the support of multiple galleries and captions in one page. I found one more problem, the gallery doesn't work with IE any more. I don't know when this hapend, but i was just checking now. |
Author
|
Did you see any errors in IE? And which version of IE? I'll take a look at it when I get a chance. Thanks, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To add a caption, simply add a caption attribute within the anchor tag that points to the image. The caption will stick to the bottom of the image. It will works the same if no caption attributes are added.