Add optional close button; minor cleanups#31
Open
driehuis wants to merge 4 commits intotutorialzine:masterfrom
Open
Add optional close button; minor cleanups#31driehuis wants to merge 4 commits intotutorialzine:masterfrom
driehuis wants to merge 4 commits intotutorialzine:masterfrom
Conversation
added 4 commits
September 14, 2014 23:06
…t from showImage, hideOverlay and showOverlay.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a close button, inspired by the patch in #20, but with an example close button added to the arrows sprite, and (commented out) code in index.html that shows how to activate the close button. By default, the close button is not shown.
Also:
Feel free to cherrypick from the commits (I wasn't aware that github pools new commits into an existing pull request).