fix(rag): use config top_k instead of hardcoded value #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phase 2 RAG search was using hardcoded top_k=10 instead of reading from config.rag.top_k (which defaults to 20). This meant RAG was only fetching 10 chunks when the user configured 20, reducing the diversity of candidate pages shown to the LLM for integration decisions. Changes: - Pass config to Phase2Screen from LogsqueakApp - Store config in Phase2Screen instance - Read config.rag.top_k in RAG worker (fallback to 10 for tests) - Add Any to typing imports Result: RAG now respects user's top_k configuration, returning more diverse candidate pages for better integration suggestions. Assisted-by: Claude Code
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #36 +/- ##
==========================================
+ Coverage 84.59% 84.61% +0.01%
==========================================
Files 48 48
Lines 5084 5088 +4
==========================================
+ Hits 4301 4305 +4
Misses 783 783 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phase 2 RAG search was using hardcoded top_k=10 instead of reading from config.rag.top_k (which defaults to 20).
This meant RAG was only fetching 10 chunks when the user configured 20, reducing the diversity of candidate pages shown to the LLM for integration decisions.
Changes:
Result: RAG now respects user's top_k configuration, returning more diverse candidate pages for better integration suggestions.
Assisted-by: Claude Code