Use py_runtime_pair from rules_python#691
Open
iteratee wants to merge 1 commit intotweag:masterfrom
Open
Conversation
py_runtime_pair was completely removed from bazel_tools with bazel 8. Using the version from rules_python should not cause problems for users of bazel 7 and earlier.
Member
|
Thank you, that looks reasonable. But CI failed with: We have to use an older rules_python version which is still compatible with Bazel 6.x. Oh, and in WORKSPACE mode, rules_python is not even available: |
Author
|
I'll see what I can do. From my testing with rules_haskell, I wasn't able to get this change to work at all with bzlmod and bazel 6. As they continue to diverge it will get harder to support more different major versions of bazel. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
py_runtime_pair was completely removed from bazel_tools with bazel 8. Using the version from rules_python should not cause problems for users of bazel 7 and earlier.
I haven't tested with earlier bazel versions. Depending on the supported range of bazel versions, I can test locally.